Drop OrdinaryDiffEqTsit5 dependency and ODE-solver helpers#212
Merged
Conversation
The OrdinaryDiffEq stack is heavy and was pulled in only for an example and one TDVP test that compared a Tsit5-based local updater against a Krylov-based one. Removing it speeds up test/example loading and avoids version-resolution friction with the broader OrdinaryDiffEq ecosystem. Source-side cleanup: - Delete `src/solvers/timedependentsum.jl` (`TimeDependentSum`, `ScaledSum`, related helpers). - Delete `src/solvers/ITensorsExtensions.jl` (`to_vec`). - Drop `TimeDependentSum` and `to_vec` from exports and from the exported-names test list. Test/example cleanup: - Delete `test/base/test_solvers/test_tdvp_time_dependent.jl` and the three `examples/solvers/03_*.jl` files (models, ODE updaters, time- dependent TDVP demo). - Rename `examples/solvers/04_tdvp_observers.jl` to `03_tdvp_observers.jl` and update the example list in `test/base/test_solvers/test_examples.jl`. - Drop `OrdinaryDiffEqTsit5` from the test, `test/base/test_solvers`, and `examples/solvers` Project.tomls; drop now-unused `Compat` and `KrylovKit` from `examples/solvers/Project.toml`. Removing the public exports `TimeDependentSum` and `to_vec` is breaking, so bump 0.3.45 -> 0.4.0 and update the package compat pin in `test/`, `docs/`, and `examples/` Project.tomls accordingly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mtfishman
force-pushed
the
mf/drop-tsit5-testdep
branch
from
0ea9876 to
5428261
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 90.33% 89.96% -0.37%
==========================================
Files 54 52 -2
Lines 3610 3577 -33
==========================================
- Hits 3261 3218 -43
- Misses 349 359 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrdinaryDiffEqTsit5as a test/example dependency. The OrdinaryDiffEq stack is heavy and was pulled in only for one TDVP test and one example that compared aTsit5-based local updater against a Krylov-based one.src/solvers/timedependentsum.jl(TimeDependentSum,ScaledSum, related helpers) andsrc/solvers/ITensorsExtensions.jl(to_vec). These existed only to plug ITensors into ODE solvers; with the ODE example/test gone there are no in-tree consumers.test/base/test_solvers/test_tdvp_time_dependent.jland theexamples/solvers/03_models.jl,03_tdvp_time_dependent.jl,03_updaters.jlfiles. Renames04_tdvp_observers.jlto03_tdvp_observers.jland updates the example list intest_examples.jlaccordingly.OrdinaryDiffEqTsit5fromtest/Project.toml,test/base/test_solvers/Project.toml, andexamples/solvers/Project.toml. Drops now-unusedCompatandKrylovKitfromexamples/solvers/Project.toml.Breaking change
TimeDependentSumandto_vecwere exported. Removing them is breaking, so this bumps the version0.3.45 -> 0.4.0and updates theITensorMPScompat pin intest/,docs/, andexamples/Project.tomls to"0.4".