FEM: Change eval functor to use struct#549
Merged
Merged
Conversation
…need of [[maybe_unused]] etc - use of struct instead
aaadelmann
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In FEM, we use a functor, EvalFunctor, representing the PDE in order to compute the matrix-vector product A*x on the fly in the finite element space. However, this was hard-coded to take only the gradient of the basis functions in Lagrange, and the curl of the basis functions + the basis functions themselves in Nédélec, where there is both a curl-curl and a mass matrix term.
Now, instead of hard-coding which quantities are needed, there is one struct which contains that basis function and its associated derivative. In the case of Lagrange, the associated derivative is the gradient, while for Nédélec it is the curl. This struct is passed to the EvalFunctor, which can use whichever quantity it needs (either for a mass term or a gradient/curl term).
This PR was made in collaboration with Cursor.