IONOS(viewer): NC33 IONOS delta — one commit per feature (HDNEXT-1585)

[printminion-co]

Summary

This is the folded variant of #45 — essentially the same IONOS viewer delta on the NC33 base
ionos-dev-v33, with the history reshaped to one commit per feature so it reads cleanly and is
ready to be proposed upstream to nextcloud/viewer.

Compared to #45 it additionally carries a small follow-up header-layout fix (see feature 2
below) and, for now, omits the recompiled assets — see the note at the bottom.

Features (6 commits)

1. feat(viewer): always-show-viewer with default fallback component — the always_show_viewer
   app config, the config module, the Default component (+ its text-color / Safari-width /
   title-color styling), default viewer registration, the fallback wiring in Viewer.vue, folder
   exclusion in the file action's enabled callback, and prev/next navigation.
2. feat(viewer): hide file name in modal header for default/image view — hides the file name in
   the modal header for the Default component and for images. Also keeps the header actions
   (play/pause, actions menu, close) right-aligned when the name is empty: NcModal omits the
   .modal-header__name element behind v-if, and its .modal-header relies on that full-width
   name to push .icons-menu right via flex space-between (no margin-left: auto fallback), so
   without it the actions collapsed to the left. Fixed with a scoped
   :deep(.modal-header .icons-menu) { margin-inline-start: auto; } — a no-op when the name is
   shown, right-aligning when it is hidden.
3. fix(viewer): exclude directories from the file list
4. feat(viewer): exclude Collabora office documents and PDFs from preview
5. fix(images): render default fallback and stop spinner on failed image load
6. fix(viewer): fix live-photo peer match for numeric-name files

Authorship across the folded commits is preserved via Co-authored-by + Signed-off-by trailers.

Relationship to #45

Supersedes-in-spirit #45, but both are intentionally left open so reviewers can compare the
granular history (#45) against this folded, upstream-ready shape.

Assets

The chore(assets): recompile viewer assets for NC33 delta commit has been dropped from this
branch. The compiled js//css/ assets still need to be rebuilt and re-committed to reflect
the source changes (notably the header-layout fix in feature 2) before this is merged.

CI note

static-psalm-analysis fails on a pre-existing base issue unrelated to this delta: the psalm job
pulls nextcloud/ocp dev-master, which now requires PHP ~8.3, while the vanilla composer.json
config.platform.php is 8.2. This affects any viewer fork PR until the base bumps the platform pin.

Jira: HDNEXT-1585

[printminion-co]

Update: header layout fix for empty modal title

Folded a follow-up fix into IONOS: feat(viewer): hide file name in modal header for default/image view (4bcf5a69).

Problem: when the modal name is empty (Default handler / always_show_viewer fallback), NcModal omits the .modal-header__name element entirely (it's rendered behind v-if="modalName"). Since NcModal's .modal-header right-aligns .icons-menu via flex + justify-content: space-between relying on that full-width name element — and has no margin-left: auto fallback — the header actions (play/pause, actions menu, close) collapsed to the left instead of the top-right.

Fix: add a scoped override in Viewer.vue that keeps the menu pinned right regardless of whether the name is present:

:deep(.modal-header .icons-menu) {
	margin-inline-start: auto;
}

It's a no-op when the name is shown (the full-width name leaves no free space for the auto margin) and right-aligns the menu when the name is hidden. The image--fullscreen case is unaffected (there the name element still exists, only opacity: 0).

ℹ️ Note: the IONOS: chore(assets): recompile viewer assets for NC33 delta commit was dropped from this branch — compiled js//css/ assets still need to be rebuilt and re-committed to reflect this source change.

[Copilot]

Pull request overview

This PR ports and reshapes the NC33 IONOS Viewer delta to support an “always show viewer” mode with a Default fallback handler, along with related modal header behavior and file list filtering/fallback behavior across the viewer and file action integration.

Changes:

• Add always_show_viewer initial-state/config plumbing and register a Default viewer handler used as a fallback when no specialized handler exists.
• Adjust viewer modal title/header behavior to hide the filename for Default/image views while keeping header actions right-aligned.
• Refine viewer navigation/list building to support default-group fallback and broadened file inclusion/exclusion rules when always-show-viewer is enabled.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/views/Viewer.vue	Adds modal title logic, default-handler/group fallback, and updated folder-list filtering when always-show-viewer is enabled.
src/utils/livePhotoUtils.ts	Adjusts live-photo peer matching to tolerate non-string basenames.
src/services/Viewer.js	Registers the new Default handler alongside existing built-in handlers.
src/models/default.ts	Introduces the Default handler model keyed to the configured default mime type.
src/models/config.ts	Adds initial-state backed config module for always-show-viewer + default mime type.
src/files_actions/viewerAction.ts	Updates viewer file-action enablement behavior for always-show-viewer and folder exclusion.
src/components/Images.vue	Renders Default fallback when original image load fails and ensures loading state is ended.
src/components/Default.vue	Adds the Default fallback UI component for unsupported file types.
lib/Listener/LoadViewerScript.php	Provides initial state for always_show_viewer to the frontend based on app config.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (3)

lib/Listener/LoadViewerScript.php:45

• IAppConfig::getAppValue requires (appId, key, default). Calling it with only (key, default) will not read the app config correctly and can fail at runtime. Use the viewer app id explicitly.

		$alwaysShowViewer = $this->appConfig->getAppValue('always_show_viewer', 'no') === 'yes';

src/views/Viewer.vue:798

• This filter does not actually exclude directories: DAV directory entries typically have a non-empty mime (e.g. httpd/unix-directory), so mime && … will still include them. Use file.type !== 'directory' (as used elsewhere in src/utils/fileUtils.ts) to reliably exclude folders from the slideshow list.

						return mime && !isOfficeDocument && !isPdf

src/files_actions/viewerAction.ts:114

• When alwaysShowViewer is enabled, the action becomes available without checking READ permission. This can expose a "View" action for items the user cannot read (or trigger avoidable errors). Keep the READ-permission requirement while still allowing any readable file type.

			// Always enabled if configured so
			if (configModule.alwaysShowViewer) {
				// disable for folders
				return !nodes.some(node => node.type === 'folder')
			}