refactor(publish): fold publish-on-merge into publish.yml (no OIDC change needed)#550
Merged
Merged
Conversation
…ange) Supersede the separate publish-on-merge.yml with a gated push:branches:[main] trigger on publish.yml — the workflow npm already trusts — so enabling publish-on-merge needs NO npm trusted-publisher/OIDC reconfiguration. The test gate is skipped on the branch path (merged code already passed PR CI; npm publish re-runs prepack build+validate), and publish runs on success-or-skipped. Trigger stays commented until un-gated. Refs #528.
Add the gated push:branches:[main] trigger, skip the heavy test job on the branch path (npm publish re-runs prepack build+validate), and run publish on test success-or-skipped. Reuses publish.yml so no npm/OIDC change. Refs #528.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes the separate `publish-on-merge.yml` (from #547) by folding publish-on-merge into the existing `publish.yml`.
Why
npm trusted publishing binds to the workflow filename. A new file (`publish-on-merge.yml`) would require registering it as a trusted publisher on npm for all ~11 packages. `publish.yml` is already the trusted publisher, so reusing it means zero npm/OIDC changes to enable publish-on-merge.
What
Un-gate later
Uncomment the `# branches: [main]` line under `push:`. No npm changes required.
Refs #528.