Send a User-Agent on live audits (fixes GitHub 403)#12
Merged
Conversation
GitHub's API rejects requests with no User-Agent (403), and workerd's fetch sends none by default — so every live audit 403'd regardless of GIT_TOKEN. The fixture-based E2E never hit the real API, so it slipped through. Wrap the audit fetch to identify the service to GitHub. chant core gets a fallback UA too (separate fix) so it never 403s in UA-less runtimes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every live
/auditreturned400 {"error":"…api.github.com/… returned 403"}— even withGIT_TOKENset. Root cause: GitHub's API 403s requests with noUser-Agent, and workerd'sfetchsends none by default. Node's fetch sends a default UA, so the CLI and the fixture-based E2E never hit it.Wrap the audit fetch (
uaFetch) to identify the service to GitHub. Fixture path is unchanged. 3 unit tests. chant core gets a fallback UA in a separate fix so the engine never 403s in UA-less runtimes.🤖 Generated with Claude Code