Do not error out if the first download attempt fails for any reason.#16
Merged
Conversation
This commit reorders the exception handling logic within the `odk-helper download` command. We catch download errors _inside_ the loop on download attempts, rather than _outside_, so that a failed download attempt (for any reason at all) does not automatically cause the command to error out without even trying the remaining attempts. Only when the _last_ attempt fails do we actually error out. This fixes INCATools/ontology-development-kit#1349.
matentzn
reviewed
May 25, 2026
Update the `odk-helper download` command to emit: * one INFO message indicating the URL that we are currently trying to download from; * one WARNING message if we fail to download from one particular URL, unless that URL was the last URL to try (in which case we error out instead of logging a warning).
matentzn
approved these changes
May 26, 2026
| raise click.ClickException(f"Cannot download {url}: {e}") | ||
| except DownloadError as e: | ||
| if i == len(attempts) - 1: | ||
| raise click.ClickException(f"Cannot download {url}: {e}") |
There was a problem hiding this comment.
Cosmetic: I assume here that the printed DownloadError always contains the response.status_code (status). If that for some unfathomable reason is not the case I would print it as part of the exception.
matentzn
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reorders the exception handling logic within the
odk-helper downloadcommand.We catch download errors inside the loop on download attempts, rather than outside, so that a failed download attempt (for any reason at all) does not automatically cause the command to error out without even trying the remaining attempts. Only when the last attempt fails do we actually error out.
This fixes INCATools/ontology-development-kit#1349.