Eagle 1039 - #616
Open
james-strauss-uwa wants to merge 45 commits into
Open
Conversation
… not yet let the user perform the updates
…ularly display of errors, warnings
… graph errors when requested
…that class. Work-in-progress.
Collaborator
|
Removing that setting is fine, that was my mistake the fix all and individual fixing of issues in the modal on load are working great. Problems: there is no way to get back to the version of the error modal that displays both, errors in the graph and in the palettes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could you take a quick look at this. Sorry, its a large code change.
The major changes are to use a common interface (a modal previously used for displaying/fixing graph errors) for three purposes:
It's useful to enable the following settings:
And test:
Also please check that removing line 345 from src/Setting.ts is OK