uc_Eating changes - #1
Conversation
Ontology changes
mateolanYolanda
left a comment
There was a problem hiding this comment.
Baton Lane 7 exact-head HOLD on 4e13303201415dade41976c475ade2450eb1f9b7.
This surface is not merge-ready:
- GitHub reports the PR as non-mergeable against
master; rebase/resolve conflicts before semantic review can be trusted. - The ontology uses workstation-local
file:/imports/...IRIs. Those imports are not portable or reproducible outside the author's Protégé environment. Replace them with stable ontology IRIs and keep local resolution only in the XML catalog (for example, map canonical BFO/RO/ENVO/CHEBI/UBERON IRIs to vendored import files). - The proposed ontology IRI is still the temporary
semanticweb.org/.../untitled-ontology-11identifier, while multiple catalog entries mark duplicate/shadowed copies. Establish one canonical persistent ontology IRI and version IRI, remove duplicate ontology artifacts, and document the release artifact. - No CI evidence exists for this head. Add at minimum an automated OWL parse/import-closure check plus a reasoner consistency check over the canonical ontology artifact.
Concrete remediation: rebase; designate ontology/uc_eating.owl (or another explicitly documented path) as the single source of truth; change <Import>file:/imports/... to canonical upstream IRIs; retain catalog mappings for offline builds; add ROBOT-based validate-profile, reason, and import-resolution checks; then request re-review on the new exact head.
ghost
left a comment
There was a problem hiding this comment.
Organization-wide watcher reconciliation on exact head 4e13303201415dade41976c475ade2450eb1f9b7.
The existing HOLD remains technically valid, but its Baton Lane 7 ownership metadata is superseded: this review is from the independent IC-FOODS/UKnowGrow organization-wide watcher, not a repository-assigned or specialist lane.
Current disposition is unchanged: the PR is non-mergeable; local file:/imports/... IRIs make import closure non-portable; the ontology still lacks a canonical persistent ontology/version IRI and single release artifact; and no automated OWL import/profile/reasoner checks are exposed for this head. Rebase and resolve conflicts, normalize canonical IRIs with catalog-based local mappings, designate one source-of-truth artifact, add ROBOT validation/reasoning CI, then request exact-head re-review.
Ontology changes