Skip to content

uc_Eating changes - #1

Open
ktaji wants to merge 1 commit into
masterfrom
uc_Eating-edits
Open

uc_Eating changes#1
ktaji wants to merge 1 commit into
masterfrom
uc_Eating-edits

Conversation

@ktaji

@ktaji ktaji commented Feb 12, 2018

Copy link
Copy Markdown
Contributor

Ontology changes

Ontology changes

@mateolanYolanda mateolanYolanda left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baton Lane 7 exact-head HOLD on 4e13303201415dade41976c475ade2450eb1f9b7.

This surface is not merge-ready:

  1. GitHub reports the PR as non-mergeable against master; rebase/resolve conflicts before semantic review can be trusted.
  2. The ontology uses workstation-local file:/imports/... IRIs. Those imports are not portable or reproducible outside the author's Protégé environment. Replace them with stable ontology IRIs and keep local resolution only in the XML catalog (for example, map canonical BFO/RO/ENVO/CHEBI/UBERON IRIs to vendored import files).
  3. The proposed ontology IRI is still the temporary semanticweb.org/.../untitled-ontology-11 identifier, while multiple catalog entries mark duplicate/shadowed copies. Establish one canonical persistent ontology IRI and version IRI, remove duplicate ontology artifacts, and document the release artifact.
  4. No CI evidence exists for this head. Add at minimum an automated OWL parse/import-closure check plus a reasoner consistency check over the canonical ontology artifact.

Concrete remediation: rebase; designate ontology/uc_eating.owl (or another explicitly documented path) as the single source of truth; change <Import>file:/imports/... to canonical upstream IRIs; retain catalog mappings for offline builds; add ROBOT-based validate-profile, reason, and import-resolution checks; then request re-review on the new exact head.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Organization-wide watcher reconciliation on exact head 4e13303201415dade41976c475ade2450eb1f9b7.

The existing HOLD remains technically valid, but its Baton Lane 7 ownership metadata is superseded: this review is from the independent IC-FOODS/UKnowGrow organization-wide watcher, not a repository-assigned or specialist lane.

Current disposition is unchanged: the PR is non-mergeable; local file:/imports/... IRIs make import closure non-portable; the ontology still lacks a canonical persistent ontology/version IRI and single release artifact; and no automated OWL import/profile/reasoner checks are exposed for this head. Rebase and resolve conflicts, normalize canonical IRIs with catalog-based local mappings, designate one source-of-truth artifact, add ROBOT validation/reasoning CI, then request exact-head re-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants