fix(visualization): update ylim function call for consistency#773
Merged
Conversation
Signed-off-by: Pablo Carmona Gonzalez <pablocarmonagonzalez@gmail.com>
5bc0a37 to
d46707e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Address recent mypy errors on visualization matplotlib module:
Details
Passing -1, 1 as separate float-compatible arguments matches the overload signature ylim(bottom, top). A list[int] technically satisfied the tuple[float, float] variant in older mypy versions via looser checking, but newer mypy is stricter about the distinction between list and tuple.
https://matplotlib.org/stable/api/_as_gen/matplotlib.pyplot.ylim.html