Repository navigation
fix: cap mcp below 2 so pip install -e . can start the MCP servers - #666
Open
vishalhabib99 wants to merge 1 commit into
Open
vishalhabib99 wants to merge 1 commit into
vishalhabib99 wants to merge 1 commit into
Conversation
All six MCP servers import mcp.server.fastmcp, which mcp 2.x removed. pyproject asks for mcp[cli]>=1.26.0 with no upper bound, so the README's pip install -e . now resolves mcp 2.3.0 and every server fails on import. uv.lock already pins 1.26.0; only the requires-dist line changes there. Signed-off-by: Vishal Habib <vishalhabib99@gmail.com>
Author
|
Hi, just checking whether this one is on your radar. It's a small fix (cap mcp below 2 so pip install -e . can start the MCP servers) and the branch is still mergeable. Happy to change anything. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The README Quick Start (
pip install -e .) installs mcp 2.3.0, and then none of the MCP servers can start.pyproject.tomlasks formcp[cli]>=1.26.0with no upper bound. mcp 2.x removedmcp.server.fastmcp, which all six servers import (iot,utilities,vibration,tsfm,fmsr,wo):uv syncusers don't see this, becauseuv.lockpins mcp 1.26.0.Fix Details
pyproject.toml:mcp[cli]>=1.26.0,<2.uv.lock: only the matchingrequires-distspecifier line. No locked versions change, anduv lock --checkpasses.With the cap, a fresh resolve gives
mcp==1.30.0andfastmcp==3.4.11. Moving the servers to the mcp 2.xMCPServerAPI can come later as a separate change.Impact on Benchmarking
Related Issues
Verification Steps
uv run pytest src/ -k "not integration": 696 passed and 8 failed. The same 8 fail onmainwithout this change (test_static_json_scorer.py×6,test_file_exporter.py×2).pip install -e .resolves mcp 2.3.0 onmain, andimport servers.<name>.mainfails for every server. On this branch it resolves mcp 1.30.0 and all six import.iotandfmsronly log missing-credential warnings.Checklist