chore: clarify user input convention for multiorbital non-reciprocal models - #12
Open
marcelolooser wants to merge 3 commits into
Open
Conversation
marcelolooser
force-pushed
the
chore/no-ref/NonReciprocalAbelianBlochHamiltonian
branch
from
June 20, 2025 17:10
ae86dfb to
359922e
Compare
marcelolooser
force-pushed
the
chore/no-ref/NonReciprocalAbelianBlochHamiltonian
branch
from
September 3, 2025 07:33
e89fe4d to
eecc377
Compare
marcelolooser
force-pushed
the
chore/no-ref/NonReciprocalAbelianBlochHamiltonian
branch
from
October 10, 2025 10:42
eecc377 to
61321a3
Compare
patrick-lenggenhager
requested changes
Oct 13, 2025
patrick-lenggenhager
left a comment
patrick-lenggenhager
left a comment
Member
There was a problem hiding this comment.
Please have a look at the comment, thanks!
Member
There was a problem hiding this comment.
The description of options is doubled. Please check if they are identical and remove one (the old) copy of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user input for the construction of non-reciprocal hyperbolic lattice models with multiple orbitals per site is not explained in detail. This PR clarifies the used conventions through a general two-orbital {p, q}-lattice model with two sites per unit cell, together with an explicit example with symbolic coupling constants.