Skip to content

0.3.1 housekeeping: install-path cleanup, Node-24 actions, SECURITY 0.3.x - #3

Draft
vveerrgg wants to merge 1 commit into
mainfrom
rel-0.3.1
Draft

vveerrgg wants to merge 1 commit into
mainfrom
rel-0.3.1

Conversation

@vveerrgg

Copy link
Copy Markdown
Contributor

Install-path script always stops the ComfyUI it started (own PID, also on SIGTERM), with a test. All actions bumped to Node-24 majors pinned by SHA; explicit ubuntu-24.04. SECURITY.md supported versions -> 0.3.x. Comfy-Org/publish-node-action still uses checkout@v4/setup-python@v5 internally (upstream, latest main d2366e7); its Node-20 warning in publish.yml cannot be fixed from here.

…tions; SECURITY 0.3.x

- scripts/install_path_check.py: ComfyUI is started inside the try, stopped by its own
  Popen handle in the finally (terminate, kill after the grace), and SIGTERM/SIGHUP raise
  so a cancelled or timed-out job still runs the finally. tests/test_install_path_stop.py.
- workflows: actions/checkout v7.0.1, setup-python v7.1.0, cache(/restore,/save) v6.1.0,
  upload-artifact v7.0.2, all node24, pinned by SHA; ubuntu-latest -> ubuntu-24.04.
- SECURITY.md: the latest 0.3.x gets fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant