fix: HeidiTips fetch timeout Illegal invocation#9773
Open
TaitChan wants to merge 1 commit into
Open
Conversation
Passing abortController.abort directly to setTimeout loses the required `this` binding and throws Illegal invocation when the 5s timeout fires while /heidi-tips is still pending. Co-authored-by: Cursor <cursoragent@cursor.com>
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Illegal invocationwhen the Heidi tips live fetch timeout fires after 5 seconds.Problem
setTimeout(abortController.abort, MAX_TIMEOUT)loses the requiredthisbinding on host methods.Fix
setTimeout(() => abortController.abort(), MAX_TIMEOUT)Repro
heidi_live_tips_collection/heidi_live_tips_collection_fetched_atin localStorage/heidi-tipsfor >5sIllegal invocationatHeidiTips/utils.tsTest plan
/heidi-tips— no console error after 5s