fix(cli install): resolve tuple unpacking bug and UX issues (#291)

[HumanBean17]

Summary

Fixes #291 - CLI install command bugs reported during testing.

Bug Fixes

1. "Index already exists" False Positive ✅

Problem: The installer always showed "Index already exists" even on fresh installations.

Root Cause: The code was using if index_dir_has_existing_artifacts(index_dir): but this function returns tuple[bool, list[str]], not a boolean. Since non-empty tuples are always truthy in Python, the condition was always True.

Fix: Properly unpack the tuple:

has_existing, _ = index_dir_has_existing_artifacts(index_dir)
if has_existing:
    print("Index already exists. Run `java-codebase-rag reprocess` to rebuild.")

2. UI Visibility on White/Light Terminal Themes ✅

Problem: Selected items were not clearly visible on white/light terminal backgrounds.

Root Cause: Default questionary styles used colors that blended with light backgrounds.

Fix: Added custom prompt_toolkit Style with:

• Bold text and darker colors (blue/cyan) for selected items
• Underline for highlighted items
• Colors that work on both light and dark backgrounds

3. UX Confusion with Agent Host Selection ✅

Problem: Users were confused when selecting agent hosts. All hosts were pre-selected by default, leading users to think they selected one host when actually all were selected.

Root Cause: Checkbox with checked: True for all items. Users unfamiliar with multi-select checkboxes didn't realize they needed to uncheck unwanted items.

Fix:

• Changed default to pre-select only claude-code (most common)
• Added help message explaining checkbox navigation ("You can select multiple agent hosts with Space. Navigate with arrow keys.")
• Added confirmation message showing what will be deployed

4. Scope Selection Clarity ✅

Problem: Users were unclear about the difference between project and user scope.

Fix: Added explanatory notes and confirmation:

• "Note: 'project' scope stores configs in the project directory."
• "Note: 'user' scope stores configs in your home directory."
• "Selected scope: {scope}"

Test Plan

• All 53 existing installer tests pass
• Verified index check logic correctly detects existing vs new indexes
• Verified styling works on both light and dark terminal themes
• Verified host selection UX improvements reduce confusion
• Verified scope selection clarity improvements

Technical Details

Files Changed: java_codebase_rag/installer.py

Lines Changed: +33, -7

Breaking Changes: None - these are pure bugfixes and UX improvements

🤖 Generated with Claude Code