add trace tool v2 proposal (#240)#258
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
HumanBean17
left a comment
There was a problem hiding this comment.
Review: Trace Tool V2 Proposal
Well-structured proposal — concrete problem statements, exceptional test plan (40 existing + 22 new tests mapped), and good resolved-decisions section. A few items to address before this lands:
Issues
1. Duplicate section numbering — "What this proposal changes" has two items numbered 4 (breaking API change, no graph schema changes). Renumber to 4–7.
2. confidence dropped from edge metadata — v1 TraceEdge included confidence. The new EdgeFromParent type has no confidence field. Is this intentional? If confidence is no longer surfaced per-edge, the proposal should say why. If it's an oversight, add confidence: float | None to EdgeFromParent.
3. Bidirectional merge — "other direction records the edge" is ambiguous — The merge semantics say "the other direction records the edge but does not duplicate the node." Does the non-first direction (a) show a TreeNode with edge_from_parent but no children, (b) drop the edge entirely, or (c) add an advisory? Option (a) seems most useful for agents. A one-liner clarification would help the implementer.
4. cross_service + direction="both" interaction — Not specified whether boundary stopping applies symmetrically in both directions during bidirectional traversal. Worth a brief note.
5. min_result_nodes retry has no upper bound — Doubling fan_out_cap is fine for small caps, but if already at 50 the retry goes to 100. Consider noting that existing BFS budget clamping still caps the retry.
Minor
_SOURCE_RELATIVE_PRIORITY: theREPOSITORYrow is missing aCONTROLLERentry (should be priority 1 for completeness, matching other rows).- Line refs in
mcp_hints.py(526, 557, 571) will likely drift — consider referencing by function name instead. - Post-merge follow-ups mention
docs/AGENT-GUIDE.md— confirmskills/explore-codebase/SKILL.mdalso gets the parallel update.
Overall: solid proposal, the issues above are clarifications not design problems. 👍
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
* add trace tool v2 proposal (#240) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * address review feedback on trace v2 proposal Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * address second review on trace v2 proposal Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
What
Added proposal file propose/active/TRACE-TOOL-V2-PROPOSE.md for trace tool v2 enhancements tracked in #240.
Why now
The trace tool v1 shipped on experimental (PR-TRACE-1a through PR-TRACE-4). Four concrete shortcomings emerged during review and production use that justify a v2 proposal.
Highlights
Tests
Docs-only; baseline unchanged.
Out of scope