Skip to content

feat(hints): describe structural hints — IMPLEMENTS/INJECTS wiring + method road signs #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HumanBean17 merged 2 commits into from
May 24, 2026
Merged

feat(hints): describe structural hints — IMPLEMENTS/INJECTS wiring + method road signs #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1eab42
feat(hints): describe structural hints — IMPLEMENTS/INJECTS wiring + …
HumanBean17 May 23, 2026
d735201
review: simplify override-axis gate, extract _record_role, remove dup…
HumanBean17 May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 93 additions & 0 deletions mcp_hints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,13 @@ def _extract_other_ids(results: list[dict[str, Any]]) -> list[str]:
TPL_DESCRIBE_ROUTE_DECLARING = "declaring method: neighbors(['{id}'],'in',['EXPOSES'])"
TPL_DESCRIBE_CLIENT_DECLARING = "declaring method: neighbors(['{id}'],'in',['DECLARES_CLIENT'])"
TPL_DESCRIBE_PRODUCER_DECLARING = "declaring method: neighbors(['{id}'],'in',['DECLARES_PRODUCER'])"
TPL_DESCRIBE_TYPE_IMPLEMENTORS = "implementors: neighbors(['{id}'],'in',['IMPLEMENTS'])"
TPL_DESCRIBE_TYPE_IMPLEMENTS = "implements: neighbors(['{id}'],'out',['IMPLEMENTS'])"
TPL_DESCRIBE_TYPE_DEPENDENCIES = "dependencies: neighbors(['{id}'],'out',['INJECTS'])"
TPL_DESCRIBE_TYPE_INJECTORS = "injectors: neighbors(['{id}'],'in',['INJECTS'])"
TPL_DESCRIBE_METHOD_OUTBOUND_CALLS = "outbound calls: neighbors(['{id}'],'out',['CALLS'])"
TPL_DESCRIBE_METHOD_SUPER_DECL = "super declaration: neighbors(['{id}'],'out',['OVERRIDES'])"
TPL_DESCRIBE_METHOD_UNRESOLVED = "unresolved: neighbors(['{id}'],'out',['CALLS'],include_unresolved=True)"

TPL_FIND_EMPTY_RESOLVE = "no matches — try resolve(identifier, hint_kind='{kind}') for canonical lookup"
TPL_FIND_PAGE_FULL = "result page full at {limit} — narrow filter or paginate"
Expand Down Expand Up @@ -254,6 +261,27 @@ def _out_count(edge_summary: dict[str, Any] | None, key: str) -> int:
return int(cell.get("out", 0) or 0)


def _in_count(edge_summary: dict[str, Any] | None, key: str) -> int:
if not edge_summary or key not in edge_summary:
return 0
cell = edge_summary[key]
if not isinstance(cell, dict):
return 0
return int(cell.get("in", 0) or 0)


def _record_role(rec: dict[str, Any]) -> str:
return str((rec.get("data") or {}).get("role") or rec.get("role") or "")


def _type_rollup_would_emit(edge_summary: dict[str, Any] | None) -> bool:
return (
_out_count(edge_summary, "DECLARES.DECLARES_CLIENT") > 0
or _out_count(edge_summary, "DECLARES.EXPOSES") > 0
or _out_count(edge_summary, "DECLARES.DECLARES_PRODUCER") > 0
)


def _symbol_declaration_kind(record: dict[str, Any]) -> str | None:
data = record.get("data")
if isinstance(data, dict):
Expand Down Expand Up @@ -1037,13 +1065,25 @@ def generate_hints(
"neighbors", {"ids": [node_id], "direction": "in", "edge_types": ["DECLARES_CLIENT"]},
True, PRIORITY_LEAF_FOLLOWUP,
))
if _out_count(edge_summary, "HTTP_CALLS") > 0:
pairs.append((PRIORITY_LEAF_FOLLOWUP, TPL_FIND_SUCCESS_HTTP_TARGETS.format(id=node_id)))
struct_pairs.append(_StructuredHint(
"neighbors", {"ids": [node_id], "direction": "out", "edge_types": ["HTTP_CALLS"]},
True, PRIORITY_LEAF_FOLLOWUP,
))
return (finalize_hint_list(pairs), finalize_structured_hints(struct_pairs))
if kind == "producer":
pairs.append((PRIORITY_LEAF_FOLLOWUP, TPL_DESCRIBE_PRODUCER_DECLARING.format(id=node_id)))
struct_pairs.append(_StructuredHint(
"neighbors", {"ids": [node_id], "direction": "in", "edge_types": ["DECLARES_PRODUCER"]},
True, PRIORITY_LEAF_FOLLOWUP,
))
if _out_count(edge_summary, "ASYNC_CALLS") > 0:
pairs.append((PRIORITY_LEAF_FOLLOWUP, TPL_FIND_SUCCESS_ASYNC_TARGETS.format(id=node_id)))
struct_pairs.append(_StructuredHint(
"neighbors", {"ids": [node_id], "direction": "out", "edge_types": ["ASYNC_CALLS"]},
True, PRIORITY_LEAF_FOLLOWUP,
))
return (finalize_hint_list(pairs), finalize_structured_hints(struct_pairs))

if kind != "symbol":
Expand Down Expand Up @@ -1078,6 +1118,33 @@ def generate_hints(
"neighbors", {"ids": [node_id], "direction": "out", "edge_types": ["DECLARES.DECLARES_PRODUCER"]},
True, PRIORITY_DECLARES_TYPE_ROLLUP,
))

if not _type_rollup_would_emit(edge_summary):
if decl_kind == "interface" and _in_count(edge_summary, "IMPLEMENTS") > 0:
pairs.append((PRIORITY_LEAF_FOLLOWUP, TPL_DESCRIBE_TYPE_IMPLEMENTORS.format(id=node_id)))
struct_pairs.append(_StructuredHint(
"neighbors", {"ids": [node_id], "direction": "in", "edge_types": ["IMPLEMENTS"]},
True, PRIORITY_LEAF_FOLLOWUP,
))
if decl_kind == "class" and _out_count(edge_summary, "IMPLEMENTS") > 0:
pairs.append((PRIORITY_LEAF_FOLLOWUP, TPL_DESCRIBE_TYPE_IMPLEMENTS.format(id=node_id)))
struct_pairs.append(_StructuredHint(
"neighbors", {"ids": [node_id], "direction": "out", "edge_types": ["IMPLEMENTS"]},
True, PRIORITY_LEAF_FOLLOWUP,
))
if decl_kind == "class" and _record_role(rec) == "SERVICE" and _out_count(edge_summary, "INJECTS") > 0:
pairs.append((PRIORITY_LEAF_FOLLOWUP, TPL_DESCRIBE_TYPE_DEPENDENCIES.format(id=node_id)))
struct_pairs.append(_StructuredHint(
"neighbors", {"ids": [node_id], "direction": "out", "edge_types": ["INJECTS"]},
True, PRIORITY_LEAF_FOLLOWUP,
))
if decl_kind in {"interface", "class"} and _in_count(edge_summary, "INJECTS") > 0:
pairs.append((PRIORITY_LEAF_FOLLOWUP, TPL_DESCRIBE_TYPE_INJECTORS.format(id=node_id)))
struct_pairs.append(_StructuredHint(
"neighbors", {"ids": [node_id], "direction": "in", "edge_types": ["INJECTS"]},
True, PRIORITY_LEAF_FOLLOWUP,
))

return (finalize_hint_list(pairs), finalize_structured_hints(struct_pairs))

if is_method:
Expand Down Expand Up @@ -1129,6 +1196,32 @@ def generate_hints(
"neighbors", {"ids": [node_id], "direction": "out", "edge_types": ["EXPOSES"]},
True, PRIORITY_LEAF_FOLLOWUP,
))
calls_out = _out_count(edge_summary, "CALLS")
if 1 <= calls_out <= 9:
method_role = _record_role(rec)
if method_role != "OTHER" or calls_out >= 3:
pairs.append((PRIORITY_LEAF_FOLLOWUP, TPL_DESCRIBE_METHOD_OUTBOUND_CALLS.format(id=node_id)))
struct_pairs.append(_StructuredHint(
"neighbors", {"ids": [node_id], "direction": "out", "edge_types": ["CALLS"]},
True, PRIORITY_LEAF_FOLLOWUP,
))
if _out_count(edge_summary, "OVERRIDES") > 0:
if _out_count(edge_summary, "OVERRIDDEN_BY") == 0:
pairs.append((PRIORITY_LEAF_FOLLOWUP, TPL_DESCRIBE_METHOD_SUPER_DECL.format(id=node_id)))
struct_pairs.append(_StructuredHint(
"neighbors", {"ids": [node_id], "direction": "out", "edge_types": ["OVERRIDES"]},
True, PRIORITY_LEAF_FOLLOWUP,
))
data = rec.get("data")
unresolved = 0
if isinstance(data, dict):
unresolved = int(data.get("unresolved_call_sites_total") or 0)
if unresolved > 0:
pairs.append((PRIORITY_LEAF_FOLLOWUP, TPL_DESCRIBE_METHOD_UNRESOLVED.format(id=node_id)))
struct_pairs.append(_StructuredHint(
"neighbors", {"ids": [node_id], "direction": "out", "edge_types": ["CALLS"], "include_unresolved": True},
True, PRIORITY_LEAF_FOLLOWUP,
))
if _out_count(edge_summary, "CALLS") >= 10:
pairs.append((PRIORITY_LEAF_FOLLOWUP, TPL_DESCRIBE_METHOD_MANY_CALLS))
struct_pairs.append(_StructuredHint(
Expand Down
0 propose/DESCRIBE-HINTS-STRUCTURAL-PROPOSE.md → ...eted/DESCRIBE-HINTS-STRUCTURAL-PROPOSE.md
View file
Open in desktop
File renamed without changes.
Loading
Loading