JS_OBJECT_NAME not defined - #2
Open
marcelo-pvn wants to merge 16 commits into
Open
Conversation
…be 1.4 Backported base commit 8ce594f23aa1 from machniak
…x was incomplete)
I created this patch to solve [this issue](fasterit#14). Please feel free to commit it. It will also be nice to have your plugin (the only one which is working on our current setup of Roundcube v1.3.7) published in the [Roundcube Plugins](https://plugins.roundcube.net/) web page.
Restore support for pre-provisioned calendars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, I really apreciate your fixes...but my logs show me a notice on that file.
File: calendar/lib/calendar_ui.php
return html::div($attrib, html::div(null, $input->show()) . html::div('formbuttons', $button->show($this->rc->gettext('upload'), array('class' => 'button mainaction', 'onclick' => JS_OBJECT_NAME . ".upload_file(this.form)"))) . html::div('hint', $this->rc->gettext(array('name' => 'maxuploadsize', 'vars' => array('size' => $max_filesize)))) );Just change the
onclick' => JS_OBJECT_NAMEtoonclick' => rcmail_output::JS_OBJECT_NAME