Validate fat slice ranges against file size - #1041
Merged
Merged
Conversation
Raise TruncatedFileError in FatFile#populate_machos when a fat_arch offset and size exceed the file.
There was a problem hiding this comment.
Copilot review overview
馃煝 Approval recommended
The bounds check is correct, documented, and adequately tested for relevant edge cases.
Review effort: Balanced
Findings: None
What changed in this PR
Validates fat Mach-O slice ranges before parsing to consistently raise TruncatedFileError.
Changes:
- Rejects slices extending beyond file bounds.
- Adds 32-bit and 64-bit malformed-slice tests.
| File | Description |
|---|---|
lib/鈥媘acho/鈥媐at_file.rb |
Adds slice bounds validation. |
test/鈥媡est_fat.rb |
Covers invalid offsets and sizes. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
MikeMcQuaid
approved these changes
Oct 2, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise TruncatedFileError in FatFile#populate_machos when a fat_arch offset and size exceed the file.
Previously, this would raise other (generic) errors or no error at all (return a partial read).
Nemotron 3 was used for identifying the original issue and writing a substantial portion of the test cases.