meshtastic 2.7.8 (new formula)#281077
Conversation
|
|
||
| depends_on "rust" => :build | ||
| depends_on "libyaml" | ||
| depends_on "python@3.14" |
There was a problem hiding this comment.
| depends_on "python@3.14" | |
| depends_on "certifi" => :no_linkage | |
| depends_on "python@3.14" | |
| pypi_packages exclude_packages: "certifi" |
Also remove rust dependency as that is only require for certifi, no?
and then rerun brew update-python-resources. Might need to rerun brew style --fix too
There was a problem hiding this comment.
You forgot to run brew update-python-resources since the certifiressource is still present (and thus duplicated)
There was a problem hiding this comment.
so yeah, you do need rust but for bleak
There was a problem hiding this comment.
Thanks! Just added it back! Looks like I should test on Linux in addition to macOS to make sure everything builds haha. A little different from contributing to the casks repo. Thanks a lot!
One question however -- it seems bleak does not need rust on macOS, should I keep it like this? (only Linux dependency requires rust but not macOS) OR should I revert back to my original where everywhere requires rust (removes the certifi dependency and also let that build from the source)
| end | ||
|
|
||
| test do | ||
| assert_match "usage:", shell_output("#{bin}/meshtastic --help") |
There was a problem hiding this comment.
Also you should indeed add more tests, as version test can be used together with other tests (like as an addition) but not as the only test. Testing is here only so we know that compilation and other build steps where successful (by running the binary).
See https://docs.brew.sh/Formula-Cookbook#add-a-test-to-the-formula
There was a problem hiding this comment.
For this part, I'm having a little hard time as this software controls an external hardware. If no external hardware is connected, it would be difficult to test the functionality. Do you have any recommendations in such case? (i.e. should I test for failure instead? like meshtastic --info should return False)
Thanks!
There was a problem hiding this comment.
i.e. should I test for failure instead?
Yes for example if it needs to connect to a device, try to run a command that would only work if it is connected, and check that it successfully failed.
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
|
PyObjC is only relevant on macOS. so add below the depends_on: on_macos do
depends_on "llvm" => :build if DevelopmentTools.clang_build_version <= 1699
end
fails_with :clang do
build 1699
cause "pyobjc-core uses `-fdisable-block-signature-string`"
endand replace your install block with if OS.mac?
ENV.append_to_cflags "-isysroot #{MacOS.sdk_path}"
else
without = resources.filter_map { |r| r.name if r.name.start_with?("pyobjc") }
end
virtualenv_install_with_resources(without:)
|
60e1137 to
5ef76ea
Compare
1515e77 to
af15c23
Compare
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?First-time contributing to
homebrew-coreand there might be places I've missed (more test required, etc.?), please let me know! ThanksThe original repo: https://github.com/meshtastic/python