Strategy API: pass all candidates, Λ, and kadd - #33
Merged
Merged
Conversation
Strategies now receive `(X, W0, H0, Hadd, Λ, kadd)`: `Hadd` holds all candidate directions as rows, aligned 1:1 with `Λ` in descending order, and each strategy defines how to interpret the requested count `kadd`. `truncating` and `joint_nnls` add exactly `kadd` components. The new `appending` strategy adds at most `kadd`, leaving the existing factors unmodified — for callers whose current components are validated, constrained, or shared with a fit over a larger domain. Its selection combines a generalized-singular-value threshold (`appending(thresh)`, default 1), a nonnegative amplitude refit that rejects candidates unable to reduce the residual and corrects the NNDSVD quadrant-truncation scale, and a relative-amplitude floor `rtol` guarding against the scale-freeness of Λ. `gsvdrecover` rejects numerically rank-deficient SVDs with a clear error rather than failing deep inside the GSVD, and `gsvdnmf` sizes its polishing run to the number of components the strategy kept. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
Whether or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strategies now receive
(X, W0, H0, Hadd, Λ, kadd):Haddholds all candidate directions as rows, aligned 1:1 withΛin descending order, and each strategy defines how to interpret the requested countkadd.truncatingandjoint_nnlsadd exactlykaddcomponents.The new
appendingstrategy adds at mostkadd, leaving the existing factors unmodified — for callers whose current components are validated, constrained, or shared with a fit over a larger domain. Its selection combines a generalized-singular-value threshold (appending(thresh), default 1), a nonnegative amplitude refit that rejects candidates unable to reduce the residual and corrects the NNDSVD quadrant-truncation scale, and a relative-amplitude floorrtolguarding against the scale-freeness of Λ.gsvdrecoverrejects numerically rank-deficient SVDs with a clear error rather than failing deep inside the GSVD, andgsvdnmfsizes its polishing run to the number of components the strategy kept.