Conversation
`any` had been implemented for two functions, `isnan` and `isinf`, because those has an efficient implementation in terms of the factors. More broadly, though, it's inconsistent to support `any` for some functions but not others. This adds a fallback that first computes the dense matrix. `issymmetric` had been implemented as a simple check of the factors, but that checks only *structural* symmetry, not *numerical* symmetry. This deletes the method.
The downside is that it adds a lot of ambiguities against banded and `AbstractTriangular` methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes API issues:
anybroadly (it was inconsistent to support justisinfandisnan)issymmetricsupport (it was structural-only)mul!methods