test(release): stop auto-maintenance racing the tag fixture cleanup - #6462
Merged
Merged
Conversation
Version drift failed on #6431, #6443 and #6456 with `rm: cannot remove '/tmp/tmp.*/checkout': Directory not empty` right after "require-release-tag-checkout tests passed": every assertion held, and only the EXIT trap failed. The fixture commits and pushes, which can spawn a detached `git maintenance run --auto` still writing into .git while the trap deletes it. Disable auto maintenance/gc for every git process in the fixture via GIT_CONFIG_COUNT, and retry the removal once. Verification: the fixture passes locally; shellcheck clean. The race was never reproduced locally, so the root cause is inferred from the log; CI reruns are the proof. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #6458
Version driftfailed on #6431, #6443 and #6456 withrm: cannot remove '/tmp/tmp.*/checkout': Directory not empty. It fails immediately afterrequire-release-tag-checkout tests passed, so every assertion held and only the EXIT trap failed.The fixture commits and pushes, which can start a detached
git maintenance run --auto. That process keeps writing into.gitwhile the trap deletes the directory. This PR:maintenance.autoandgc.autofor every git process in the fixture, viaGIT_CONFIG_COUNTVerification: the fixture passes locally and shellcheck is clean. I have not reproduced the race locally; the cause is inferred from the log, so reruns in CI are the proof.
🤖 Generated with Claude Code