Skip to content

feat(tui): localized approval summaries; footer marks the permission - #6447

Open
Hmbown wants to merge 3 commits into
mainfrom
feat/localized-approval-footer
Open

Hmbown wants to merge 3 commits into
mainfrom
feat/localized-approval-footer

Conversation

@Hmbown

@Hmbown Hmbown commented Sep 23, 2026

Copy link
Copy Markdown
Owner

No-Issue: 0.10.1 experience marks 4 and 8; no public issue.

Experience marks 4 and 8 (0.10.1):

  • The approval card led with a plain summary of the call only in
    English; other languages fell back to the bare tool name. The summary
    is now localized in all 15 packs, around the verbatim command, path or
    query (29 new message ids).
  • The footer's permission chip is marked and followed by what its key
    does ("Shift+Tab to change", localized), so the permission in force
    reads without color instead of looking like one more word (key)
    option.
  • A footer notice whose value had to be shed no longer shrinks to a bare
    label: Thinking: high → max · model … cut to Thinking read as a live
    indicator in an idle footer.

Mined from the unreviewed 0.10.1 WIP branch. Correction: the WIP deleted
the four footer goldens without re-blessing, which fails
footer_matches_goldens_at_blocker_sizes; they are re-blessed and each
changes by exactly the intended line (at 80 columns the longer key hint
sheds the session clock, per the existing shed order). Spot-checked
zh-Hans, ja and de strings; placeholders match English in every pack.

Evidence: codewhale-localization 50 passed, 0 failed; 605 passed,
0 failed (12,655 skipped) across phase_strip, approval, widgets,
tideline and footer selections. TUI + localization all-target/all-
feature Clippy with CI flags and fmt passed.

🤖 Generated with Claude Code

Experience marks 4 and 8 (0.10.1):
- The approval card led with a plain summary of the call only in
  English; other languages fell back to the bare tool name. The summary
  is now localized in all 15 packs, around the verbatim command, path or
  query (29 new message ids).
- The footer's permission chip is marked `●` and followed by what its key
  does ("Shift+Tab to change", localized), so the permission in force
  reads without color instead of looking like one more `word (key)`
  option.
- A footer notice whose value had to be shed no longer shrinks to a bare
  label: `Thinking: high → max · model …` cut to `Thinking` read as a live
  indicator in an idle footer.

Mined from the unreviewed 0.10.1 WIP branch. Correction: the WIP deleted
the four footer goldens without re-blessing, which fails
footer_matches_goldens_at_blocker_sizes; they are re-blessed and each
changes by exactly the intended line (at 80 columns the longer key hint
sheds the session clock, per the existing shed order). Spot-checked
zh-Hans, ja and de strings; placeholders match English in every pack.

Evidence: codewhale-localization 50 passed, 0 failed; 605 passed,
0 failed (12,655 skipped) across phase_strip, approval, widgets,
tideline and footer selections. TUI + localization all-target/all-
feature Clippy with CI flags and fmt passed.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 23, 2026 16:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

CodeWhale Bot and others added 2 commits September 23, 2026 09:43
…ssion chip

The Settings theme preview renders the footer permission chip, which now
carries the current-permission mark. Only the preview line changes
("Preview:  ask" -> "Preview:  ● ask"); config_panel_40x12 regenerates
unchanged. Missed by the footer slice's test selection.

Evidence: config_panel_golden_at_eighty_and_one_twenty passes; 1612
passed, 0 failed across views::, golden, phase_strip, settings and
related selections.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The previous commit on this branch swept in unrelated, already-staged
Fleet work (runtime_api, subagent, views, docs). This restores those
files to their state before it, leaving only the two Settings preview
goldens. No force-push.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants