Conversation
Refs #6435. When the To-do/Plan lock was busy, ShellSpawnIntentGuard logged "registration skipped; running without a bound operation" and dropped its copy of the lifecycle, but the spawn path kept its own clone, published the new shell to the never-registered operation, treated that failure as fatal, killed the child and reported "Shell execution failed: operation binding shell:<id> is not registered". The reporter's logs show 563 such misses. The lifecycle used after spawn now comes from the guard, so an unbound spawn stays unbound, in both the background and interactive paths. The spawn-time publication is best-effort like every other lifecycle observation: a graph write that fails after the child started must not kill it. The try-lock spin that triggers the skip is unchanged; it now only costs Work-graph bookkeeping for that command, never the command. Evidence: new busy_work_graph_still_runs_the_command holds the To-do lock and runs a foreground and a background command with a lifecycle; against the previous code it fails (0 passed, 1 failed: the background child is killed on the missing binding), with the fix 154 passed, 0 failed across the busy_work_graph and shell:: selections. TUI all-target/all-feature Clippy with CI flags and fmt passed; blocking call budget unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #6435. When the To-do/Plan lock was busy, ShellSpawnIntentGuard
logged "registration skipped; running without a bound operation" and
dropped its copy of the lifecycle, but the spawn path kept its own
clone, published the new shell to the never-registered operation,
treated that failure as fatal, killed the child and reported "Shell
execution failed: operation binding shell: is not registered". The
reporter's logs show 563 such misses.
The lifecycle used after spawn now comes from the guard, so an unbound
spawn stays unbound, in both the background and interactive paths. The
spawn-time publication is best-effort like every other lifecycle
observation: a graph write that fails after the child started must not
kill it. The try-lock spin that triggers the skip is unchanged; it now
only costs Work-graph bookkeeping for that command, never the command.
Evidence: new busy_work_graph_still_runs_the_command holds the To-do
lock and runs a foreground and a background command with a lifecycle;
against the previous code it fails (0 passed, 1 failed: the background
child is killed on the missing binding), with the fix 154 passed,
0 failed across the busy_work_graph and shell:: selections. TUI
all-target/all-feature Clippy with CI flags and fmt passed; blocking
call budget unchanged.
🤖 Generated with Claude Code