fix(tui): register debt compatibility aliases#4680
Conversation
Move /slop and /canzha into DEBT_INFO so dispatch, help, slash completion, and typo suggestions share one registry source of truth. Rename the description key around canonical /debt wording, update command-dispatch docs, and add focused registry/help/completion regression coverage. Refs Hmbown#3914 Signed-off-by: Nightt <87569709+nightt5879@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 696860150c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Filter built-in help topics, advertised aliases, and typo candidates against the current workspace user-command registry so discovery matches dispatch precedence. Cover canonical and alias-based shadows for /slop and /canzha while keeping canonical /debt help and typo suggestions available. Addresses Codex review on Hmbown#4680. Signed-off-by: Nightt <87569709+nightt5879@users.noreply.github.com>
|
@codex review Please review updated head 584dc18. The prior P2 is fixed by filtering built-in help topics, advertised aliases, and typo candidates against the workspace user-command registry; its thread is resolved with focused and full command-test evidence. Please check the final shadowing semantics and regression coverage. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 584dc181f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Filter built-in alias copy and search metadata through the workspace user-command registry so Help and slash completion match dispatch. Cover hidden, alias, and canonical shadows in focused regression tests. Signed-off-by: Nightt <87569709+nightt5879@users.noreply.github.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Fixes #3914
Summary
/slopand/canzhaas/debtaliases inDEBT_INFO, so dispatch and discovery share one source of truth./debt, update command-dispatch documentation, and add focused alias, shadowing, help, search, and completion coverage.Testing
cargo fmt --all -- --checkcargo clippy -p codewhale-tui --bin codewhale-tui --locked --no-deps(no warnings from this patch; four pre-existing warnings remain in untouched code)cargo test -p codewhale-tui --bin codewhale-tui --locked commands::(582 passed)cargo test -p codewhale-tui --bin codewhale-tui --locked tui::views::help::tests::(24 passed)cargo test -p codewhale-tui --bin codewhale-tui --locked slash_completion_hints(20 passed)cargo test -p codewhale-tui --bin codewhale-tui --locked localization::tests::(19 passed)cargo test -p codewhale-tui --bin codewhale-tui --locked debt_(3 passed)cargo test --workspace --exclude codewhale-tui --exclude codewhale-lane --lockedcargo test --workspace --all-featurescargo clippy --workspace --all-targets --all-featuresThe final full local TUI run reached 7,683 passed with three unrelated local/parallel failures and two ignored tests. Two stable environment failures reproduce outside this patch: PowerShell
echoemits UTF-16 foroperate_model_shell_uses_normal_approval_and_workspace_sandbox, and a real home-directory instructions file triggerssystem_prompt_prefix_never_leaks_private_content. The third,approval_required_awaits_external_decision_allow, passed immediately in isolation and is a parallel timing flake. The workspace run includingcodewhale-lanealso hits its pre-existing Windows-onlyechoexecutable assumption.Checklist