🧹 Remove legacy quick-add memory binding

[Hmbown]

🎯 What: Removed the legacy "quick-add memory" binding and its associated logic (e.g., handle_memory_quick_add, should_intercept_memory_quick_add) from crates/tui/src/tui/ui.rs. Also fixed an unrelated clippy::collapsible_if warning in crates/cli/src/lib.rs.
💡 Why: To improve code maintainability and readability by removing code that has been superseded by a new feature (Moraine recall) and was marked with a TODO to remove.
✅ Verification: Verified by running cargo check, cargo clippy, and cargo test --workspace. Confirmed the legacy quick add logic is fully removed and no references were left behind.
✨ Result: A cleaner codebase with less dead/legacy code.

---

PR created automatically by Jules for task 17562081153137800995 started by @Hmbown

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[cursor]

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[claude]

Claude finished @Hmbown's task in 2m 12s —— View job

---

Review: Remove legacy quick-add memory binding

• Gather context (read diff, changed files)
• Review crates/tui/src/tui/ui.rs removal
• Review crates/cli/src/lib.rs clippy fix
• Check for leftover references / dead code
• Post final review

Note: I wasn't able to run cargo check / cargo clippy / cargo test in this sandbox (Bash execution requires interactive approval that isn't available here), so this review is based on static reading of the diff and a repo-wide grep for leftover references. The PR description says these were run locally by the author with success.

Summary

The removal itself is clean: is_memory_quick_add, should_intercept_memory_quick_add, handle_memory_quick_add, and their test module are fully deleted from crates/tui/src/tui/ui.rs, and a repo-wide grep confirms no other code references them. The remaining memory machinery (memory_enabled, moraine_fallback, memory_path, crate::memory::append_entry, the remember tool, the <user_memory> system-prompt block) is still exercised elsewhere and is untouched, so nothing was made dead by this change. The crates/cli/src/lib.rs change is a correct, behavior-preserving clippy::collapsible_if fix (same condition, same body).

Finding: stale user-facing help text (not touched by this PR, but now incorrect)

crates/tui/src/commands/groups/memory/memory.rs still tells users to use the removed feature:

• Line 40-41 (/memory help): "Quick capture: type # foo in the composer to append a timestamped bullet without firing a turn."
• Line 60 (empty-file message): "add via # foo from the composer or have the model use the remember tool"
• Line 65 (missing-file message): "add via # foo from the composer to create it"

Since should_intercept_memory_quick_add/handle_memory_quick_add are gone, typing # foo in the composer now just submits it as a normal chat turn instead of writing to the memory file. A user following this in-app help text will get silently wrong behavior (their "memory note" becomes a model prompt instead). Worth a follow-up to strip these three references and point users at the remember tool only.

(I couldn't post this as an inline PR comment — GitHub rejects inline comments on files not part of this PR's diff — so noting it here instead.)

Related stale doc comments (lower priority, doc-only, same root cause):

• crates/tui/src/tui/app.rs:1834-1838 — use_memory doc still says it's "Used by the # foo composer interception."
• crates/tui/src/core/engine.rs:373-376 — moraine_fallback doc still says "# foo quick-add falls through."
• crates/tui/src/memory.rs module docs (lines 19-20, 31-32) — presented as historical/legacy docs under a "Legacy docs (pre-Moraine)" heading, so less urgent, but now describe a feature that no longer exists at all.

No correctness bugs, provider/model-routing concerns, or security issues in the diff itself — this is a pure deletion plus an unrelated formatting-driven clippy fix.

[Hmbown]

Closing as a duplicate of #4447. #4447 is the cleaner quick-add removal slice; this branch also carries unrelated CLI formatting cleanup. The retained work is deferred to the explicit Moraine v0.9.4 migration.

[google-labs-jules]

Closing as a duplicate of #4447. #4447 is the cleaner quick-add removal slice; this branch also carries unrelated CLI formatting cleanup. The retained work is deferred to the explicit Moraine v0.9.4 migration.

Understood. Acknowledging that this work is now obsolete as it's a duplicate of #4447, and stopping work on this task.