Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
name: CI

on:
push:
branches:
- main
pull_request:

permissions:
Expand Down
22 changes: 13 additions & 9 deletions .github/workflows/deploy-gh-pages.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
name: Deploy to GitHub Pages

# Task 2.1: Trigger using workflow_run to wait for CI completion
# Pattern: workflow_run event ensures deployment only runs after CI passes
# Research: Task 1.3 confirmed needs: [ci] doesn't work across workflow files
# TEMPORARILY DISABLED
# Uncomment the 'on' block below to re-enable
#
# on:
# workflow_run:
# workflows: ['CI']
# types:
# - completed
# branches:
# - main

# Disabled - manual trigger only for now
on:
workflow_run:
workflows: ['CI'] # Must match name in .github/workflows/ci.yml
types:
- completed
branches:
- main
workflow_dispatch:

# Top-level permissions for safety (deploy job has its own)
# Pattern from: .github/workflows/ci.yml:9-11
Expand Down
243 changes: 0 additions & 243 deletions .github/workflows/publish-on-branch.yml

This file was deleted.

20 changes: 13 additions & 7 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
# TAG-BASED RELEASE WORKFLOW
# This workflow is triggered when git tags are pushed.
# Use this for: Emergency hotfixes, automated releases
# TAG-BASED RELEASE WORKFLOW (EMERGENCY USE ONLY)
# This workflow is triggered when git tags are pushed manually.
#
# For standard releases with PR review, use the branch-based workflow:
# - Create PR to release/angular-3d or release/angular-gsap
# - See docs/publishing/README.md for details
# ⚠️ IMPORTANT: For standard releases, just merge PRs to main.
# Release Please will automatically create release PRs and publish.
#
# Use this workflow ONLY for:
# - Emergency hotfixes that bypass the normal flow
# - Manual re-publishing of failed releases
#
# To use:
# git tag "@hive-academy/angular-3d@1.2.3"
# git push origin "@hive-academy/angular-3d@1.2.3"

name: Publish to NPM
name: Publish to NPM (Manual Tag)

on:
push:
Expand Down
Loading