🧹 Refactor BusinessCard component #519
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,13 +1,11 @@ | ||||||
| import { forwardRef } from "react"; | ||||||
| import type { CardBlockId, CardDisplayOptions, CardLayout, UserSummary } from "@/lib/types"; | ||||||
| import { DEFAULT_CARD_LAYOUT } from "@/lib/types"; | ||||||
| import { AvatarBlock } from "./business-card/AvatarBlock"; | ||||||
| import { BioBlock } from "./business-card/BioBlock"; | ||||||
| import { StatsBlock } from "./business-card/StatsBlock"; | ||||||
| import { TopLanguagesBlock } from "./business-card/TopLanguagesBlock"; | ||||||
| import { TopReposBlock } from "./business-card/TopReposBlock"; | ||||||
|
|
||||||
| type Props = { | ||||||
| summary: UserSummary; | ||||||
|
|
@@ -21,18 +19,7 @@ const BusinessCard = forwardRef<HTMLDivElement, Props>(({ summary, layout, optio | |||||
| if (!profile) return null; | ||||||
|
|
||||||
| const activeLayout = layout ?? DEFAULT_CARD_LAYOUT; | ||||||
|
|
||||||
|
|
||||||
| const topLanguages = repositories?.languages.slice(0, 5) || []; | ||||||
| const topTopics = repositories?.topics.slice(0, 10) || []; | ||||||
|
|
@@ -41,265 +28,33 @@ const BusinessCard = forwardRef<HTMLDivElement, Props>(({ summary, layout, optio | |||||
| ? profile.pinnedRepos.slice(0, 2) | ||||||
| : repositories?.topRepos.slice(0, 2) || []; | ||||||
|
|
||||||
|
|
||||||
| const renderBlock = (blockId: CardBlockId) => { | ||||||
| if (blockId === "avatar") { | ||||||
| return <AvatarBlock profile={profile} />; | ||||||
| } | ||||||
| if (blockId === "bio") { | ||||||
| return <BioBlock profile={profile} options={options || {}} />; | ||||||
| } | ||||||
| if (blockId === "stats") { | ||||||
| return <StatsBlock profile={profile} contributions={contributions} options={options || {}} />; | ||||||
| } | ||||||
| if (blockId === "topLanguages") { | ||||||
| return ( | ||||||
| <TopLanguagesBlock | ||||||
| topLanguages={topLanguages} | ||||||
| topTopics={topTopics} | ||||||
| interests={interests} | ||||||
| activity={activity} | ||||||
| options={options || {}} | ||||||
| /> | ||||||
| ); | ||||||
| } | ||||||
| if (blockId === "topRepos") { | ||||||
| return <TopReposBlock reposToShow={reposToShow} />; | ||||||
| } | ||||||
| return null; | ||||||
|
Contributor
There was a problem hiding this comment.
Suggested change
Knowledge Base Used: Frontend component library (src/components) Prompt To Fix With AIThis is a comment left during a code review.
Path: src/components/BusinessCard.tsx
Line: 56
Comment:
**既定ブロックの描画消失**
`DEFAULT_CARD_LAYOUT` に含まれる `profile`、`contributions`、`heatmap`、`interests`、`skills` は上の分岐で処理されないため、ここで `null` となります。設定未保存時の標準プレビューと PNG エクスポートでは、以前リポジトリ内容を表示していたこれらのスロットが空になります。
```suggestion
return <TopReposBlock reposToShow={reposToShow} />;
```
**Knowledge Base Used:** [Frontend component library (src/components)](https://app.greptile.com/hiroki-org/-/custom-context/knowledge-base/hiroki-org/github-user-summary/-/docs/frontend-components.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Comment on lines
32
to
+56
There was a problem hiding this comment. 2. Unhandled blocks render nothing BusinessCard.renderBlock returns null for valid CardBlockId values like "profile", "contributions", "heatmap", "interests", and "skills", so those layout sections render no content. Since DEFAULT_CARD_LAYOUT includes these IDs as visible full-column blocks (and layout normalization re-adds them), the default/normalized BusinessCard output can silently drop entire sections. Agent Prompt
|
||||||
| }; | ||||||
| const fullBlocks = activeLayout.blocks.filter((block) => block.column === "full" && block.visible); | ||||||
| const leftBlocks = activeLayout.blocks.filter((block) => block.column === "left" && block.visible); | ||||||
| const rightBlocks = activeLayout.blocks.filter((block) => block.column === "right" && block.visible); | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import type { UserProfile } from "@/lib/types"; | ||
|
|
||
| export const AvatarBlock = ({ profile }: { profile: UserProfile }) => ( | ||
| <div className="mb-10 flex items-center gap-8"> | ||
| {/* eslint-disable-next-line @next/next/no-img-element */} | ||
| <img | ||
| src={profile.avatar_url} | ||
| alt={profile.login} | ||
| className="h-40 w-40 rounded-full border-4 border-card-border shadow-xl" | ||
| crossOrigin="anonymous" | ||
| /> | ||
| <div className="min-w-0 flex-1"> | ||
| <h1 className="mb-2 break-words text-5xl font-bold leading-tight tracking-tight text-white"> | ||
| {profile.name || profile.login} | ||
| </h1> | ||
| <p className="break-all text-3xl font-medium text-gray-400">@{profile.login}</p> | ||
| </div> | ||
| </div> | ||
| ); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Relative imports in businesscard.tsx
📘 Rule violation✧ QualityAgent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools