Reorganize the demo agent-server by org, drop the old test agents - #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The demo's
agents/package had grown into a flat pile: four real agents, four throwaway reference/test agents, framework translators, the dispatcher, and the agent contract all sitting side by side, with every agent's UI config living separately underui/. Hard to tell which files were product and which were scaffolding, and nothing signalled which agents belonged to which audience.What changed
1. Agents are now grouped by org, with UI config co-located
Each agent lives in its own folder holding its sources and its
ui.yaml:HR is used by both audiences, so it sits in a neutral
shared/rather than under either org.2. Removed the old reference/test agents
Deleted
probe,atlas,forge,orbitand their backing code (echo.py,llm.py,adk_llm.py,demos.py,tools.py, and the fourui/*.yaml). Trimmed them out of the roster and the dispatcher accordingly —select_agentnow serves only the four real agents.3. Moved non-agent sources out of
agents/So
agents/contains only agent implementations:frameworks/package (google_adk.py,openai_agents.py,langchain_events.py)Agentcontract →base.pyat the package root, next toprotocol.pyselect.pyat the root, next to theroster.pyit mirrors4. Cleaned up the resulting dead references
Dropped the now-unused
enable_llm/AGENT_ENABLE_LLMsetting fromconfig.py, the unreachable Orbitsourceswidget actions fromactions.py, and a staleLLMAgentcomment in__main__.py.Net
+72 / −707across 43 files. All moves are puregit mvrenames, so history is preserved.Verification
create_app()), the roster lists exactly the four agents, each dispatches to the correct implementation and loads itsui.yaml.frameworks/modules import cleanly.ruff check src/agent_serverpasses.Note for reviewers
The roster's public
ui_urls (/agents/{id}/ui) are unchanged — only the on-disk layout moved, so the proxy/shell contract is unaffected. If any docs (e.g.CONTRACT.md) reference the oldagent_server.agents.baseoragent_server.agents.<translator>paths, those would need a follow-up grep.