Fixed typo on skill_attack re value comparison.#3391
Open
MrKeiKun wants to merge 1 commit into
Open
Conversation
MrKeiKun
force-pushed
the
fix-3320-typo-dmg_lv
branch
from
1e482bc to
9ffa86b
Compare
Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
MrKeiKun
force-pushed
the
fix-3320-typo-dmg_lv
branch
from
9ffa86b to
a072529
Compare
hemagx
requested changes
May 23, 2026
Contributor
hemagx
left a comment
hemagx
left a comment
There was a problem hiding this comment.
I'm not sure I see the typo and this is mostly because you basically did style changing in same commit as fixing the issue, those shall be seperated, at best you should only fix the styling in the EXACT lines the change happened. please fix this or change the PR to a styling fix instead.
| }else | ||
| battle->delay_damage(tick, dmg.amotion,src,bl,dmg.flag,skill_id,skill_lv,damage,dmg.dmg_lv,dmg.dmotion, additional_effects); | ||
| if (dmg.amotion != 0) { | ||
| if (shadow_flag == true) |
Contributor
There was a problem hiding this comment.
true checks doesn't need to have == true only false checks are encouraged to do that instead of using !
| battle->delay_damage(tick, dmg.amotion,src,bl,dmg.flag,skill_id,skill_lv,damage,dmg.dmg_lv,dmg.dmotion, additional_effects); | ||
| if (dmg.amotion != 0) { | ||
| if (shadow_flag == true) | ||
| if (status->isdead(bl) == 0 && additional_effects == true) { |
Contributor
There was a problem hiding this comment.
Same here, perhaps keep status->isdead(bl) as it is for now, it's weird but it's an integer function returning a boolean, perhaps the function type shall be changed instead in a different PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Issues addressed: #3320