Scan all JVM Kotlin modules in CodeQL#18
Merged
Conversation
The manual-build compile step only covered 8 of the 12 JVM-compiling modules, so CodeQL never extracted :samples-cli (CLI entrypoint), :test-support-wat (WAT lexer/binary writer parsing untrusted text), :annotations, or :benchmarks. Add their compile tasks so the security-extended queries see that code. :footprint-baseline and :footprint-core declare only an iosArm64 target and have no JVM compilation, so they stay out. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CodeQL manual-build compile step only compiled 8 of the 12 modules that produce JVM Kotlin classes. CodeQL's Kotlin extractor only sees code that is compiled during the build step, so these modules were never scanned:
:samples-cli(wasm-cli) — CLI entrypoint:test-support-wat(wasm-wat) — WAT lexer and binary writer that parse untrusted text input:annotations(wasm-annotations):benchmarksThe WAT parser and CLI are exactly the kind of untrusted-input surface the security-extended query pack targets, and none of it was visible to the scan.
New task list in the compile step:
Inclusion rationale: every module with a JVM Kotlin compilation is now compiled — KMP modules via
compileKotlinJvm, the pure-JVM:samples-cliviacompileKotlin(matching how the extractor picks up:bindgen-ksp/:gradle-plugin).:footprint-baselineand:footprint-coredeclare only aniosArm64target, so they have no JVM compilation and cannot be extracted by the java-kotlin scan.Verified locally: the full gradlew command from the edited step builds successfully, and all four new task paths were confirmed with
--dry-run.Note: this touches the same
runblock as the sibling PR adding cache-busting flags to the compile step, so a trivial merge conflict is possible.🤖 Generated with Claude Code