Give plugin functional-test polling a CI-sized timeout#16
Merged
Conversation
The continuous-reload functional test polls for Gradle TestKit continuous-build activity with a 30s ceiling. On loaded GitHub-hosted runners the first continuous build plus the 600ms quiet period regularly needs more than that, so the test times out in awaitCondition (KwasmPluginFunctionalTest.kt:627) while passing locally, failing CI runs 29676886384 and 29678913141 without any product change. Raise the polling default to 120s; the poll still returns as soon as the condition holds, so healthy runs are not slowed down. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
JVM and build toolingfails intermittently onKwasmPluginFunctionalTest > continuous reload watches the linked wasm and debounces changeswithjava.lang.AssertionError at KwasmPluginFunctionalTest.kt:627— theawaitConditiontimeout assert. Failed on main and on PR #12's run, passed on PR #5's run and passes locally: a classic slow-runner flake, not a product regression.The test drives a real Gradle TestKit
--continuousbuild (start-up, file-watching registration, a 600 ms quiet period, then a rebuild) and polls each phase with a 30 s ceiling. On a loaded shared runner the first continuous build alone can eat most of that budget.Fix
Raise the
awaitConditiondefault timeout from 30 s to 120 s. Polling still returns the moment the condition holds, so green runs stay exactly as fast; only genuinely stuck runs wait longer before failing.🤖 Generated with Claude Code