Stabilize snapshot suspension safety test#12
Merged
Conversation
CI run 29678913141 showed suspendedHostImportMayResumeOnAnotherThread WithoutLosingGuestState resuming on an unexpected thread: InHostImport is published before the import's continuation actually parks, so a completion racing that window finishes the await without the intended thread hop. Poll Store.captureSnapshotState until it stops throwing — the capture gate can only be acquired once the running segment has suspended and released the store execution gate — before handing the result to the resumer thread, mirroring the dispatcher drain the other test already uses. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
IRus
marked this pull request as ready for review
July 19, 2026 09:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InHostImportalone does not prove that the host continuation is parkedRoot cause
StoreStatus.InHostImportis published before the host coroutine actually suspends and releases the store execution gate. Under CI scheduling, snapshot capture could race that still-running continuation and correctly fail withSnapshotStateExceptionatStore.kt:983.The dispatcher barrier proves that the prior invocation segment has suspended before capture begins. This changes test synchronization only; runtime behavior remains unchanged.
Validation
SnapshotSuspensionSafetyJvmTest10 times with JDK 17 andCI=truemain