Skip to content

[server] allow disabling stale context cleanup #12939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Simn merged 1 commit into from
Jun 11, 2026
+7 −4
Merged

[server] allow disabling stale context cleanup #12939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/compiler/server/serverCache.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,9 +570,11 @@ let cleanup sctx =
(* Remove context caches that haven't been accessed within the max age window.
This prevents unbounded accumulation of stale contexts when compilation defines
change between requests, generating new cache signatures each time. *)
let removed = sctx.cs#remove_stale_contexts !ServerConfig.stale_context_max_age_seconds in
if removed > 0 then
ServerMessage.message (Printf.sprintf "Removed %d stale context cache(s)" removed)
if !ServerConfig.stale_context_max_age_seconds > -1 then begin
let removed = sctx.cs#remove_stale_contexts !ServerConfig.stale_context_max_age_seconds in
if removed > 0 then
ServerMessage.message (Printf.sprintf "Removed %d stale context cache(s)" removed)
end

let before_anything sctx ctx =
ensure_macro_setup sctx
Expand Down
3 changes: 2 additions & 1 deletion src/compiler/server/serverConfig.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ let max_completion_items = ref 0

(* Maximum age in seconds for unused context caches before they are removed.
10 minutes is long enough to survive bursts of display requests with
varying defines, while still cleaning up contexts that are truly abandoned. *)
varying defines, while still cleaning up contexts that are truly abandoned.
If set to -1, the feature is disabled. *)
let default_stale_context_max_age = 600
let stale_context_max_age_seconds = ref default_stale_context_max_age

Expand Down
Loading