[typer] allow int/i64 literals as haxe.Int64 default argument values#12923
Draft
kLabz wants to merge 1 commit into
Draft
[typer] allow int/i64 literals as haxe.Int64 default argument values#12923kLabz wants to merge 1 commit into
kLabz wants to merge 1 commit into
Conversation
Int64 values are never compile-time constants (they are built through Int64.make), so they were rejected as default argument values. Accept an int or i64 literal default for a haxe.Int64 argument and let each generator materialize the constant expression on the not-passed path (no Null<> boxing, so no overhead on value-type targets like hl). Not supported on cpp yet (default_value_string can't render an Int64), so it errors there for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Int64 values are never compile-time constants (they are built through Int64.make), so they were rejected as default argument values. Accept an int or i64 literal default for a haxe.Int64 argument and let each generator materialize the constant expression on the not-passed path (no Null<> boxing, so no overhead on value-type targets like hl).
Not supported on cpp yet (default_value_string can't render an Int64), so it errors there for now.