feat(engine): add order-insensitive container node matching - #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
What Changed
IsUnorderedflag toASTNodeand hooked up anunorderedlist torules.ymlso languages can mark order-insensitive containers.internal/actions/chawathe.goto skip sequence LCS alignment for unordered containers, matching mapped children directly so reordered keys don't trigger fake Move actions.BottomUpcandidate matching ininternal/engine/bottom-up.gousinggetKeyLabelto pair unordered container children by key name instead of line position.internal/actions/chawathe_test.goand updated baseline integration test fixtures intests/testdata/.Visual Comparison
tests/testdata/py_requests_environment_bundle/Before
'verify': verify, cause of reordering in the return order.After