Repository navigation
Conversation
0f1724a updated both READMEs' install pins from v1.3.0 to v1.3.1 and removed the release-candidate wording, but left the assertion in tests/readme-consistency.test.ts:104 at ['1.3.0']. Core v1.3.1 is published (draft=false, prerelease=false), so the test now fails on main itself and is inherited by every PR's plugin-tests job. Update the expected pin and its stale comment. One assertion, no README, product code, or other 1.3.0 reference touched.
|
Closing as redundant — the fix is already on This PR changes the same single assertion ( Your analysis was correct and is preserved: I read both of your comments on #7 and this PR's body while reviewing. You had explicitly left the choice of wording to the maintainer ("close it and fix it yourself if you prefer"), so I took the direct-to-main route to unblock the base first. The only difference is the comment wording (mine is shorter and does not cite the commit hash) — no semantic difference, no loss of attribution: you are credited in the #7 review and in issue #6's closing note.
|
What this is
A one-line test expectation + its stale comment, split out of #7 on purpose. It fixes the single red that
maincurrently carries into every PR'splugin tests on linuxjob.0f1724a— "docs: reflect Core v1.3.1 as released (README pins, pairing table, stale RC note)" — updated both READMEs' install examples tosessionFlow.git@v1.3.1, updated the compatibility table to1.2.0 ↔ v1.3.1, and removed the "v1.3.1 is a release candidate" wording from the READMEs. Core v1.3.1 is published (draft: false,prerelease: false, 2026-11-11T16:04:55Z).tests/readme-consistency.test.tswas not updated in that commit. Lines 102–104 still say:So the test now fails on
mainitself withactual ['1.3.1'] / expected ['1.3.0'].Evidence that this is base-carried, not introduced by a PR
0f1724a:43063357502→completed/failure, 5 cold-start matrix jobs green, onlyplugin tests on linuxred oninstall examples pin a version, not a moving branch(pass 101 / fail 1). Previous commite85f397's run42993530120was success, so it localizes to0f1724a.43073295149has the same singlenot okand nothing else; it touches onlytests/bridge.test.ts+CHANGELOG.md.mainsnapshot with zero PR changes:node --experimental-strip-types --test tests/readme-consistency.test.ts→6 tests / 5 pass / 1 fail, the one failure above.The change — 1 file, 3 lines
No README, no product code, no other
1.3.0reference touched. The remainingv1.3.0mentions in the repo are the historical1.1.0 ↔ v1.3.0compatibility row, dependency prerelease pins (0.1.5-rc.3etc.), and the "v1.3.1 is additive over v1.3.0" note — all still correct.Verification
main, single file (before)6 tests / 5 pass / 1 fail(actual ['1.3.1'] / expected ['1.3.0'])6 / 6 pass / 0 fail['1.3.0']5 pass / 1 fail); restored byte-identically →0 failnpm ci/npm run buildnpm test(no core installed)102 tests / 82 pass / 0 fail / 20 skippedThe mutation step matters here: a version-bump assertion is trivially satisfiable, so the check is that reverting it to the pre-fix value turns the test red — i.e. it actually guards the pin rather than being a no-op.
Why a separate PR
Issue #6 is scoped to test-harness hygiene only and #7 is deliberately 2 files with CI already run. Folding this in would have made #7 3 files and invalidated its completed CI run — the exact "don't widen scope" constraint I committed to there. A standalone PR keeps both independently reviewable: you can take this one first to unblock
main, or close it and fix it yourself if you prefer a different release-note wording.I am not merging anything, and I will not push further commits to this branch after CI, so the result cannot be invalidated by a re-run. Decision on the release-note/comment wording stays yours — only the assertion value is a factual consequence of
0f1724a+ the published v1.3.1 tag.Branch based on current upstream
main(0f1724a), one parent, diff is exactly the one file above.