Forbid stores from being shared - #719
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new test case to verify that a RocksDatabase instance can be successfully initialized using the store of another instance. The review feedback suggests expanding this test to verify two-way functionality by ensuring that write operations on the new database instance are also readable from the original instance.
Contributor
📊 Benchmark Resultsget-sync.bench.tsgetSync() > random keys - small key size (100 records)
getSync() > sequential keys - small key size (100 records)
ranges.bench.tsgetRange() > small range (100 records, 50 range)
realistic-load.bench.tsRealistic write load with workers > write variable records with transaction log
transaction-log.bench.tsTransaction log > read 100 iterators while write log with 100 byte records
Transaction log > read one entry from random position from log with 1000 100 byte records
worker-put-sync.bench.tsputSync() > random keys - small key size (100 records, 10 workers)
worker-transaction-log.bench.tsTransaction log with workers > write log with 100 byte records
Results from commit 54baa6c |
kriszyp
approved these changes
Jul 23, 2026
| } | ||
| }); | ||
|
|
||
| it('should allow sharing the store between databases', () => |
Member
There was a problem hiding this comment.
LGTM, do you think we should update this?:
Could we reconcile this supported-behavior test with the Store JSDoc at src/store.ts:141, which currently says that a store should not be shared between RocksDatabase instances? If sharing is intended, please update that contract here and document the shared-close lifetime this test asserts; otherwise future users and maintainers have two contradictory ownership rules.
A Store owns a single NativeDatabase handle and is 1:1 with a RocksDatabase. Reusing one store across two RocksDatabase instances aliased the handle (surprising close-cascade and shared encoder state). Enforce the invariant: each RocksDatabase claims its store on construction via Store#claim(), which throws if the store is already owned by another RocksDatabase. The claim is durable across close/reopen so a temporarily-closed owner does not release it. Sharing a store with the owning database's Transaction instances is unaffected. Document in the Store jsdoc, the constructor `store` option, and the Custom Store README section. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
cb1kenobi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing https://github.com/HarperFast/harper/pull/1888/changes#diff-4ff51263bd99981165fc179149c3195ea0c0ca3e2f360bafee2a6bb356964377R605, I realized it's technically possible to share stores between
RocksDatabaseinstances. The store owns the native DB handle and sharing could lead to bugs. It's best to forbid stores from being shared.