Enforce table read permissions for subscriptions on Harper 5.1#1914
Open
kriszyp wants to merge 2 commits into
Open
Enforce table read permissions for subscriptions on Harper 5.1#1914kriszyp wants to merge 2 commits into
kriszyp wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces permission checks to the table subscription process in resources/Table.ts and adds corresponding unit tests in permissions.test.js. The review feedback recommends guarding against potential nullish context values using optional chaining to prevent runtime errors, and suggests using assert.strictEqual instead of assert.equal in the test suite to align with the repository's style guide.
Member
Author
|
Main/5.2 follow-up with full connection + per-record authorization semantics: #1915 |
kriszyp
marked this pull request as ready for review
July 23, 2026 23:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures tables using
loadAsInstance = falseinvokeallowReadbefore subscription setup, matching the existinggetauthorization contract and preventing checked subscriptions from bypassing table read permissions. This intentionally preserves v5.1 table-level semantics instead of backporting main’s row-level delivery behavior; generated by GPT-5.6 Codex.Attention: cross-model coverage was Gemini ✓ / Harper domain pass ✓ / Codex CLI timeout. The full integration matrix reached 1,321 passes and zero assertion failures; its command exited nonzero only because the unrelated real-Ollama fixture hit Node
ERR_IMPORT_ATTRIBUTE_MISSINGwhile loadingjson/systemSchema.jsonand cancelled six children.