ci: run a single Node version for integration tests on PR pushes#1883
Open
kriszyp wants to merge 1 commit into
Open
ci: run a single Node version for integration tests on PR pushes#1883kriszyp wants to merge 1 commit into
kriszyp wants to merge 1 commit into
Conversation
PR pushes were building and testing the full Node 22/24/26 x 6-shard integration matrix on every push, tripling CI cost/latency for a signal that rarely differs across Node versions during review. Trim PR pushes to Node 24 only (representative). Keep the full matrix on push to main/release branches, and add a nightly cron (07:00 UTC) so regressions on 22/26 are still caught daily rather than only at merge time. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
|
Reviewed; no blockers found. |
kriszyp
marked this pull request as ready for review
July 21, 2026 11:49
Ethan-Arrowood
approved these changes
Jul 23, 2026
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
Member
There was a problem hiding this comment.
LGTM. Workflow logic traced across all four triggers — PR pushes run Node 24 only, full 22/24/26 matrix retained on main + nightly, so coverage is deferred, not lost. Confirmed the integration jobs aren't required status checks, so the matrix trim won't strand PRs on a check that never reports.
Non-blocking follow-up: this same Node-matrix trim is duplicated in harper-pro#601 — worth extracting into a shared reusable workflow so the two repos don't drift.
sent with Claude Opus 4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Trims integration-test CI cost on PR pushes without losing cross-version coverage:
22/24/26matrix — dropping therun-integration-testsfan-out from 18 shards to 6.22/24/26matrix still runs on pushes tomain/release branches, and on a new nightly schedule (0 7 * * *).workflow_dispatchbehavior is unchanged (still respects thenode-versioninput).Windows/Bun/uWS variant jobs are untouched. Shard counts are unchanged (already 6-way).
Why
Every PR push was paying for the full three-Node matrix, tripling integration compute and stretching the wall-clock that CI-monitoring sessions wait on. Cross-Node regressions are still caught on
mainand nightly; per-push we only need one representative version.Risk
Low. A Node-version-specific regression would surface on the next
mainpush / nightly rather than on the PR push itself — an acceptable trade for the dev-loop speedup. The change is a conditional in the existinggenerate-node-version-matrixjob.— KrAIs (Claude Opus 4.8)
🤖 Generated with Claude Code