Hamed R. - #1
Open
HamedRazizadeh-hub wants to merge 1 commit into
Open
Hamed R.#1HamedRazizadeh-hub wants to merge 1 commit into
HamedRazizadeh-hub wants to merge 1 commit into
Conversation
rafasilpereira
left a comment
rafasilpereira
left a comment
There was a problem hiding this comment.
You forgot to add the screenshots:
- mobile-screenshot.png — page at 375px, single column, no overflow
- axe-screenshot.png — axe DevTools run showing zero critical errors
rafasilpereira
left a comment
rafasilpereira
left a comment
There was a problem hiding this comment.
Very good work! The page looks great
| @@ -0,0 +1,334 @@ | |||
| *, | |||
There was a problem hiding this comment.
Tip: You have a lot of colors in your css, maybe creating custom properties would make it easier to use and avoid duplications?
| width: 13rem; | ||
| height: 13rem; | ||
| border-radius: 50%; | ||
| object-fit: cover; |
There was a problem hiding this comment.
Great use of this property: this makes sure that the image appears in good proportion in all screens
| padding: 1.5rem; | ||
| background-color: white; | ||
| border: 0.125rem solid #bae6fd; | ||
| border-radius: 1rem; |
There was a problem hiding this comment.
You only used rem, which is a great approach for responsive design.
Comment on lines
+22
to
+24
| main, | ||
| footer { | ||
| display: grid; |
There was a problem hiding this comment.
Why header and footer needs grid template?
rafasilpereira
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.