-
Notifications
You must be signed in to change notification settings - Fork 9
Baraah A. #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thebaraah
wants to merge
2
commits into
HackYourAssignment:main
Choose a base branch
from
thebaraah:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Baraah A. #3
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| [ | ||
| { | ||
| "id": 1, | ||
| "name": "Alice Johnson", | ||
| "email": "alice.johnson@company.com", | ||
| "department": "Engineering", | ||
| "salary": 85000 | ||
| }, | ||
| { | ||
| "id": 2, | ||
| "name": "Bob Smith", | ||
| "email": "bob.smith@company.com", | ||
| "department": "Unknown", | ||
| "salary": 72000 | ||
| }, | ||
| { | ||
| "id": 3, | ||
| "name": "Carol Williams", | ||
| "email": "carol.williams@company.com", | ||
| "department": "Engineering", | ||
| "salary": null | ||
| }, | ||
| { | ||
| "id": 4, | ||
| "name": "David, Jr.", | ||
| "email": "david.brown@company.com", | ||
| "department": "Sales", | ||
| "salary": 68000 | ||
| }, | ||
| { | ||
| "id": 5, | ||
| "name": "Caf\u00e9 Owner", | ||
| "email": "eva@company.com", | ||
| "department": "Engineering", | ||
| "salary": 88000 | ||
| }, | ||
| { | ||
| "id": 6, | ||
| "name": "FRANK WILSON", | ||
| "email": "frank@company.com", | ||
| "department": "marketing", | ||
| "salary": 95000 | ||
| }, | ||
| { | ||
| "id": 7, | ||
| "name": "Grace Lee", | ||
| "email": "grace.lee@company.com", | ||
| "department": "Engineering", | ||
| "salary": null | ||
| }, | ||
| { | ||
| "id": 9, | ||
| "name": "Henry Davis", | ||
| "email": "henry.davis@company.com", | ||
| "department": "Sales", | ||
| "salary": 82000 | ||
| }, | ||
| { | ||
| "id": 11, | ||
| "name": "Linda Taylor", | ||
| "email": "linda.t@company.com", | ||
| "department": "HR", | ||
| "salary": 55000 | ||
| }, | ||
| { | ||
| "id": 12, | ||
| "name": "Mike Brown", | ||
| "email": "mike.b@company.com", | ||
| "department": "Sales", | ||
| "salary": null | ||
| }, | ||
| { | ||
| "id": 13, | ||
| "name": "Sarah Connor", | ||
| "email": "s.connor@sky.net", | ||
| "department": "Unknown", | ||
| "salary": -1 | ||
| }, | ||
| { | ||
| "id": 15, | ||
| "name": "John Doe", | ||
| "email": "john.doe@company.net", | ||
| "department": "Engineering", | ||
| "salary": 100000 | ||
| } | ||
| ] |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,9 @@ def clean_name(raw: str) -> str: | |
|
|
||
| Returns the cleaned string. An empty input returns "". | ||
| """ | ||
| if raw is None: | ||
| return "" | ||
| return raw.strip() | ||
| raise NotImplementedError("Implement clean_name (Task 1)") | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please remove the NotImplementedError from your helpers since you've already added the functionality |
||
|
|
||
|
|
||
|
|
@@ -21,6 +24,9 @@ def clean_email(raw: str) -> str: | |
|
|
||
| Returns the cleaned string. An empty input returns "". | ||
| """ | ||
| if raw is None: | ||
| return "" | ||
| return raw.lower().strip() | ||
| raise NotImplementedError("Implement clean_email (Task 1)") | ||
|
|
||
|
|
||
|
|
@@ -29,6 +35,12 @@ def clean_department(raw: str) -> str: | |
|
|
||
| Strip whitespace; treat empty string as missing. | ||
| """ | ||
| if raw is None: | ||
| return "Unknown" | ||
| department = raw.strip() | ||
| if department =="": | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: add spaces after == |
||
| return "Unknown" | ||
| return department | ||
| raise NotImplementedError("Implement clean_department (Task 1)") | ||
|
|
||
|
|
||
|
|
@@ -38,4 +50,19 @@ def clean_salary(raw: str) -> int | None: | |
| Handles inputs like "85000", " 95000", '"68,000"', "N/A", "". | ||
| Returns None when the value cannot be parsed (missing or "N/A"). | ||
| """ | ||
| if raw is None: | ||
| return None | ||
|
|
||
| salary = raw.strip() | ||
|
|
||
| salary = salary.replace('"','').replace(',','') | ||
|
|
||
| if salary =="" or salary == "N/A": | ||
| return None | ||
|
|
||
| try: | ||
| return int(salary) | ||
| except ValueError: | ||
| return None | ||
|
|
||
| raise NotImplementedError("Implement clean_salary (Task 1)") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DictReader values are usually strings, so better to use if not raw than if raw is None