Conversation
|
Nice work, your pipeline produces the correct 12-row output, all 4 tests pass, and your Azure upload looks good. 4/5. |
qira-a
reviewed
Jun 4, 2026
Comment on lines
+20
to
+21
| input_path = (os.environ["INPUT_PATH"]) | ||
| output_path =(os.environ["OUTPUT_PATH"]) |
There was a problem hiding this comment.
These two lines load env vars before _required() runs, and they use os.environ["INPUT_PATH"] which raises KeyError (not ValueError) if missing.
You already have the correct solution on lines 43–44. Please delete lines 20–21 and 33–36, and keep only:
INPUT_PATH: str = _required("INPUT_PATH")
OUTPUT_PATH: str = _required("OUTPUT_PATH")
|
Please remove |
qira-a
reviewed
Jun 4, 2026
| with open(path, mode='r', encoding='utf-8') as file: | ||
| reader = csv.DictReader(file) | ||
| return list(reader) | ||
| raise NotImplementedError |
qira-a
reviewed
Jun 4, 2026
| vat: float = 0.0 | ||
|
|
||
| def __post_init__(self): | ||
| if (self.price <= 0): |
There was a problem hiding this comment.
the assignment says reject negative prices, kindly change to <0
qira-a
reviewed
Jun 4, 2026
Comment on lines
+40
to
+41
| { | ||
| **row, # ✅ spread pattern - copies all existing fields |
There was a problem hiding this comment.
Put {**row, ...} on one line so the auto grader can work correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.