-
Notifications
You must be signed in to change notification settings - Fork 7
Mohamad bader AA #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
noneeeed
wants to merge
8
commits into
HackYourAssignment:main
Choose a base branch
from
noneeeed:week11-attempt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mohamad bader AA #12
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6e7bb4b
filled metric definitions
noneeeed 9d4452c
created streamlit dashboard
noneeeed 810eb3f
added metabase pdf
noneeeed 9d83794
added streamlit screenshot/ renmaed folder to docs
noneeeed 52bc83f
added AI assist
noneeeed 7d59df3
added links to ## My submission
noneeeed 4fde2df
moved metric definistions to correct folder
noneeeed c8a6fae
added metabase screenshot
noneeeed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| # Metric definitions | ||
|
|
||
| Five fields per metric: Name, Description, Calculation, Data source, Refresh frequency. One block per panel. Copy this file to `metric_definitions.md` inside your `week11-streamlit/` folder and fill it in. | ||
|
|
||
| ## Metabase panels | ||
|
|
||
|
|
||
| ### Panel 1: Trip count | ||
|
|
||
| - **Name**: Trip count by payment type | ||
| - **Description**: bar chart to understand which payment methods are most popular among riders. | ||
| Y axis is trip count, X axis is payment type | ||
| - **Calculation**: `COUNT(*)` grouped by `payment_type_label` where `payment_type_label IS NOT NULL` | ||
| - **Data source**: dev_bader.fct_trips | ||
| - **Refresh frequency**: once per day | ||
|
|
||
| ### Panel 2: Average fare | ||
|
|
||
| - **Name**: Average Fare per Mile by Dropoff Borough | ||
| - **Description**: Identify which destinations have the highest average fares per mile | ||
| X is dropoff borough and Y is average fare per mile | ||
| - **Calculation**: `AVG(fare_per_mile)` grouped by `dropoff_borough` where `dropoff_borough IS NOT NULL` | ||
| - **Data source**: dev_bader.fct_trips | ||
| - **Refresh frequency**: once per day | ||
|
|
||
| ### Panel 3: Average trip duration | ||
|
|
||
| - **Name**: Average Trip Duration by hour of day | ||
| - **Description**: Track how the average trip length in minutes during hours of the day | ||
| X axis and Y are hours of the day, Line is the average trip duration in minutes | ||
| - **Calculation**: `AVG((dropoff_datetime - pickup_datetime) in minutes)` grouped by `EXTRACT(HOUR FROM pickup_datetime)` | ||
| - **Data source**: dev_bader.fct_trips | ||
| - **Refresh frequency**: once per day | ||
|
|
||
| ## Streamlit panels | ||
|
|
||
|
|
||
| ### Panel 1: Headline KPIs | ||
|
|
||
| - **Name**: Total Trips, Average Trip Distance, Average Fare per Mile | ||
| - **Description**: Count of trips, mean trip distance, and mean fare per mile | ||
| - **Calculation**: `count(*)`, `avg(trip_distance)`, `avg(fare_per_mile)` | ||
| - **Data source**: `dev_bader.fct_trips` | ||
| - **Refresh frequency**: 5 min cache (`ttl=300`) | ||
|
|
||
| ### Panel 2: Trips by Hour of Day | ||
|
|
||
| - **Name**: Trip Count by Pickup Hour | ||
| - **Description**: Trip count grouped by hour of day | ||
| - **Calculation**: `count(*) group by extract(hour from pickup_datetime)` | ||
| - **Data source**: `dev_bader.fct_trips` | ||
| - **Refresh frequency**: 5 min cache (`ttl=300`) | ||
|
|
||
| ### Panel 3: Data Freshness | ||
|
|
||
| - **Name**: Row Count, Latest Pickup Timestamp | ||
| - **Description**: Total rows and most recent pickup timestamp | ||
| - **Calculation**: `count(*)`, `max(pickup_datetime)` | ||
| - **Data source**: `dev_bader.fct_trips` | ||
| - **Refresh frequency**: 5 min cache (`ttl=300`) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can ask the LLM to just display the answer and not implement anything, so you avoid it adding stuff everywhere unasked.