Monerh A

[Miuroro]

No description provided.

[github-actions]

📝 HackYourFuture auto grade

Assignment Score: 100 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 50
🧪 The auto grade is experimental and still being improved

Test Details

Vitest unit test results:

✅ post.sh: Script exists
✅ post.sh: Create user John Doe
✅ patch.sh: Script exists
✅ patch.sh: Correct the email address
✅ get.sh: Script exists
✅ get.sh: Retrieve user John Doe details
✅ delete.sh: Script exists
✅ delete.sh: Delete user John Doe
✅ get.sh: Verify user John Doe has been deleted
✅ Uses the correct base URL
✅ URL includes the nobelPrizeYear query parameter
✅ URL includes the nobelPrizeCategory query parameter
✅ URL includes the offset query parameter
✅ URL includes the limit query parameter
✅ Omits the nobelPrizeYear when set to "all"
✅ Omits the nobelPrizeCategory when set to "all"
✅ Includes the sort query parameter set to desc

Total passed: 17
Total failed: 0
Killed

[remarcmij]

Hi @Miuroro, good work. One minor simplification could be made, see my comment below.

[remarcmij]

This will work too, because filters.year will be undefined if the .year property does not exist, and undefined !== 'all. Some for .category.

Suggested change

	if (filters.year && filters.year !== 'all') {
	url += `&nobelPrizeYear=${filters.year}`;
	}
	if (filters.category && filters.category !== 'all'){
	url += `&nobelPrizeCategory=${filters.category}`;
	}
	if (filters.year !== 'all') {
	url += `&nobelPrizeYear=${filters.year}`;
	}
	if (filters.category !== 'all'){
	url += `&nobelPrizeCategory=${filters.category}`;
	}