-
Notifications
You must be signed in to change notification settings - Fork 19
Atiqa N. #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Atiqa N. #19
Changes from all commits
ca96e2f
3bd052f
0227019
f35100f
c949050
743fc9d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: main | ||
|
|
||
| jobs: | ||
| ci: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm install | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For study purposes this works well, but I would recommend the reading of npm ci and how it deffers from npm install. When working in deployed a software it could have a difference |
||
| working-directory: ./task-1 | ||
|
|
||
| - name: Run linter | ||
| run: npm run lint | ||
| working-directory: ./task-1 | ||
|
|
||
| - name: Run unit tests | ||
| run: npm test | ||
| working-directory: ./task-1 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can use |
||
|
|
||
| - name: Build the React application | ||
| run: npm run build | ||
| working-directory: ./task-1 | ||
|
|
||
| - name: Zip the build output | ||
| run: zip -r task-1-dist.zip task-1/dist | ||
|
|
||
| - name: Upload build artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: build-artifact | ||
| path: task-1-dist.zip | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,4 +3,4 @@ The week 13 assignment for the HackYourFuture Core program can be found at the f | |
|
|
||
| ## Implementation Instructions | ||
| ### Task 1 | ||
| Add your gitHub action file in `.github/workflows/task-1.yaml` (Note: inside the existing .github folder found on the root of the repository) | ||
| Add your gitHub action file in `.github/workflows/task-1.yaml` (Note: inside the existing .github folder found on the root of the repository) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The only change here is removing the trailing newline at the end of the file. This was probably done by your editor automatically. You can revert it by run: |
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even the assignement is not mentioning it, it's a good practice of setting the node version. Curiosity: why 20?