Skip to content

Salem Ba-Rabuod - #17

Open
Barboud wants to merge 6 commits into
HackYourAssignment:mainfrom
Barboud:main
Open

Barboud wants to merge 6 commits into
HackYourAssignment:mainfrom
Barboud:main

Conversation

@Barboud

@Barboud Barboud commented Apr 8, 2026

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown

📝 HackYourFuture auto grade

Assignment Score: 0 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 0
🧪 The auto grade is experimental and still being improved

Test Details

@mvcatsifma
mvcatsifma self-requested a review April 16, 2026 10:26
@mvcatsifma

Copy link
Copy Markdown

Good work — all requirements are met: lint, tests, build, the artifact is explicitly zipped before uploading, and the linter fix is correct. The pipeline ran and passed.

A few things to improve for next time:

Wrong filename — the README specifies .github/workflows/task-1.yaml, but the file is named weather-app.yml. Follow the naming convention given in the instructions.

Commit hygiene — 6 commits for this task is too many. Aim for one commit per concern: one for the CI pipeline, one for the linter fix.

Unnecessary style changes in SearchBar.tsx — the only linter error was the unused variable. The quote normalization changes throughout the file were not required and unrelated to the task. Keep changes focused.

@mvcatsifma mvcatsifma added the Reviewed This assignment has been reivewed by a mentor and a feedback has been provided label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants