Mohammed A - #12
Open
mohammedalfakih-dev wants to merge 1 commit into
Open
Mohammed A#12mohammedalfakih-dev wants to merge 1 commit into
mohammedalfakih-dev wants to merge 1 commit into
Conversation
📝 HackYourFuture auto gradeAssignment Score: 0 / 100 ✅Status: ✅ Passed Test Details |
rafaelhdr
approved these changes
Apr 16, 2026
rafaelhdr
left a comment
rafaelhdr
left a comment
There was a problem hiding this comment.
Congrats. Just minor comments, but all good.
| branches: | ||
| - main | ||
| - master | ||
| pull_request: |
There was a problem hiding this comment.
Nice that you have main and master for push, but shouldn't you also limit in the pull request? To not build on every PR?
|
|
||
| defaults: | ||
| run: | ||
| working-directory: task-1 |
There was a problem hiding this comment.
This is good approach. Make easier than repeat on every step.
| cache-dependency-path: task-1/package-lock.json | ||
|
|
||
| - name: Install dependencies | ||
| run: npm install |
There was a problem hiding this comment.
In a github action, the ideal is to use npm ci instead of the npm install
| run: npm run lint | ||
|
|
||
| - name: Run unit tests | ||
| run: npm test -- --run |
There was a problem hiding this comment.
Why the -- --run instead of only the npm test?
rafaelhdr
added
the
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.