Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions .github/workflows/task-1.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
name: Task 1 CI

on:
push:
branches: [main]
pull_request:
branches: [main]

jobs:
ci:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 20

- name: Install dependencies
run: npm ci

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you used ci instead of install. It is the best approach

working-directory: task-1

- name: Run linter
run: npm run lint
working-directory: task-1

- name: Run tests
run: npm run test
working-directory: task-1

- name: Build project
run: npm run build
working-directory: task-1

- name: Zip dist
run: zip -r dist.zip dist
working-directory: task-1

- name: Upload artifact
uses: actions/upload-artifact@v4
with:
name: weather-build
path: task-1/dist.zip
30 changes: 0 additions & 30 deletions task-1/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions task-1/src/components/SearchBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ interface Props {

export function SearchBar({ onSearch, loading }: Props) {
const [value, setValue] = useState("");
const unusedConstMaybeDeleteMe = "Search";


const handleSubmit = (e: FormEvent) => {
e.preventDefault();
if (value.trim()) onSearch(value);
Expand Down