Skip to content

Pavel T - #17

Open
pavel-tisner wants to merge 3 commits into
HackYourAssignment:mainfrom
pavel-tisner:main
Open

pavel-tisner wants to merge 3 commits into
HackYourAssignment:mainfrom
pavel-tisner:main

Conversation

@pavel-tisner

Copy link
Copy Markdown

No description provided.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

📝 HackYourFuture auto grade

Assignment Score: 0 / 100 ✅

Status: ✅ Passed
Minimum score to pass: 0
🧪 The auto grade is experimental and still being improved

Test Details

@rafaelhdr rafaelhdr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Your code is well indented and easy to read.

Congratulations 👏

Comment thread task-1/queries.sql

-- **Question 6** — Add one book for the author you just inserted. It can be a real book or a made-up one.
INSERT INTO books (title, published_year, genre, author_id)
VALUES ('My way', 2026, 'Fiction', (SELECT id FROM authors WHERE last_name = 'Tisner'));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a very good solution. Here, I would recommend add more fields to the WHERE (not just the last name Tisner), to avoid get users with the same last name.

Comment thread task-1/queries.sql
-- **Question 7** — The genre for "The Dark Tower: The Gunslinger" was entered incorrectly as `'Fantasy'`. It should be `'Horror'`. Write an UPDATE to fix it, then verify the change with a SELECT.
UPDATE books
SET genre = 'Fantasy'
WHERE title = 'Harry Potter and the Deathly Hallows';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is wrong here. It wasn't expected to be Harry Potter.

Comment thread task-2/src/database.js
const updatedCard = db
.prepare(`SELECT * FROM cards WHERE id = ?`)
.get(cardId);
updatedCard.learned = true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line works, but it might make some confusion.

In all other methods, learned is an integer (0 or 1). This is the only case you are treating it as boolean.

It is fine for the exercise, but ideally it should always be the same (always integer 0 or 1, or always boolean false or true)

@rafaelhdr rafaelhdr added Reviewed This assignment has been reivewed by a mentor and a feedback has been provided and removed Review in progress labels Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants